d/datastore_cluster: New data source #437
Conversation
This is a data source counterpart to the vsphere_datastore_cluster resource, designed to fetch the ID of a datastore cluster only as we want to be able to provide a data source avenue for this data, to ensure that people can use existing infrastructure that was not created in Terraform.
vancluever
added
enhancement
| } | ||
|
|
||
| func dataSourceVSphereDatastoreClusterRead(d *schema.ResourceData, meta interface{}) error { | ||
| pod, err := resourceVSphereDatastoreClusterGetPodFromPath(meta, d.Get("name").(string), d.Get("datacenter_id").(string)) |
There was a problem hiding this comment.
It looks like the way to reference a datastore that is in a folder would be to set name to the absolute path of the datastore. Would it work to have folder as part of the data source? That feel like it would be more intuitive.
There was a problem hiding this comment.
Actually, a short-form name works regardless of where the datastore cluster is in inventory. Since we use Finder to ultimately look for most objects when searching by name or path, the same rule apply. See https://godoc.org/github.com/vmware/govmomi/find and https://github.com/vmware/govmomi/blob/master/govc/README.md#usage for more details on how paths can be searched on in govmomi.
There was a problem hiding this comment.
Got it. Looks good then!
ghost
locked and limited conversation to collaborators
This is a data source counterpart to the
vsphere_datastore_clusterresource, designed to fetch the ID of a datastore cluster only as we
want to be able to provide a data source avenue for this data, to ensure
that people can use existing infrastructure that was not created in
Terraform.