add vm configure latencySensitivity support #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougm
reviewed
Apr 25, 2018
| "latency_sensitivity": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Default: "normal", |
There was a problem hiding this comment.
Could use the govmomi generated const here: types.LatencySensitivitySensitivityLevelNormal
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Default: "normal", | ||
| Description: "The latency-sensitivity setting of the virtual machine.", |
There was a problem hiding this comment.
Maybe include the possible values here?
* Added validation for allowed values. * Added detailed description on what latency sensitivity does. * Added test for setting, setting sensitivity to high and setting a 100% memory reservation (which seems to be necessary). * Updated docs. Also added warning on the above info, and that low and medium levels aren't available on ESXi >= 6.0.
vancluever
approved these changes
Apr 26, 2018
|
@vancluever thanks a lot. |
ghost
locked and limited conversation to collaborators
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #387
high LatencySensitivity VM is important when customers trying to reduce VM latency for applications.
now users can configure high LatencySensitivity VM with following terraform parameters:
latency_sensitivity = "high" memory_reservation = $memorytested with a vSphere cluster(vCenter and ESX), govc and
Terraform v0.11.3
appreciate your review in advance.