New resource: vsphere_compute_cluster_vm_group #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vancluever
added
enhancement
Addresses some comments referring to incorrect resource names in most of the override source files.
This is the full resource CRUD and import functionality for the vsphere_cluster_vm_group resource. Tests will come next.
A number of things are in this update: * First off, we've renamed the resource to vsphere_compute_cluster_vm_group. This is because the groups are actually located within a cluster configuration and are not transferrable to any other kind of cluster (ie: datastore clusters, which actually don't have groups at all). * Second off, we've had to add extra lookup logic to translate VM UUIDs to MoRefs. This has been added into the shared helper package so it can be re-used for upcoming work easier (as we add rules, there will be a number of places this needs to be changed too). * Lastly, tests have been added and the work necessary to get them working has been done. Completion is pending documentation.
And a small doc correction in the schema.
This is currently broken - from the looks of it there are some resource or configuration issues starting the website docker container that need fixing.
vancluever
force-pushed
the
f-vsphere-cluster-vm-group-resource
branch
from
90d03e5 to
81e9632
Compare
bill-rich
approved these changes
May 10, 2018
| return moids | ||
| } | ||
|
|
||
| // ManagedObjectReferences returns all MOIDs in a MOIDForUUIDResults, as ManagedObjectReferences as type VirtualMachine. |
ghost
locked and limited conversation to collaborators
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all of the work for the
vsphere_compute_cluster_vm_groupresource. This will be used as an input to a couple of the upcoming cluster rule resources.