Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Vendor: Update govmomi to v0.18 #600

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Vendor: Update govmomi to v0.18 #600

merged 1 commit into from
Aug 24, 2018

Conversation

bill-rich
Copy link
Contributor

No description provided.

@bill-rich bill-rich changed the title [WIP] Vendor: Update govmomi to v0.18 Vendor: Update govmomi to v0.18 Aug 23, 2018
@bill-rich bill-rich requested a review from a team August 23, 2018 17:51
@ghost ghost added the size/xxl Relative Sizing: Extra-Extra-Large label Aug 23, 2018
@ghost ghost added the size/xxl Relative Sizing: Extra-Extra-Large label Aug 23, 2018
@bill-rich bill-rich requested a review from vancluever August 23, 2018 20:30
tombuildsstuff
tombuildsstuff approved these changes Aug 24, 2018
View reviewed changes
Copy link

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'm assuming thing still compile/the tests pass 👍

@bill-rich
Copy link
Contributor Author

Yep, all tests still pass! Thanks!

@bill-rich bill-rich merged commit c14a70d into master Aug 24, 2018
@bill-rich bill-rich deleted the v-govmomi-update branch August 24, 2018 15:34
@bill-rich bill-rich mentioned this pull request Aug 24, 2018
Closed
@Russell-IO Russell-IO mentioned this pull request Sep 7, 2018
Closed
@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@vancluever vancluever Awaiting requested review from vancluever

Assignees
No one assigned
Labels
size/xxl Relative Sizing: Extra-Extra-Large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bill-rich @tombuildsstuff