Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

r/virtual_machine: Unlock memory reservation #680

Merged
merged 1 commit into from
Jan 7, 2019
Merged

r/virtual_machine: Unlock memory reservation #680

merged 1 commit into from
Jan 7, 2019

Conversation

bill-rich
Copy link
Contributor

@bill-rich bill-rich commented Jan 4, 2019 •
edited
Loading

Unlock the memory reservation from the allocation if the reservation is
lower than the allocation.

Fixes #672

@bill-rich
r/virtual_machine: Unlock memory reservation
2609307 
Unlock the memory reservation from the allocation if the reservation is
lower than the allocation.
@bill-rich bill-rich requested a review from a team January 4, 2019 19:12
@ghost ghost added the size/s Relative Sizing: Small label Jan 4, 2019
tombuildsstuff
tombuildsstuff reviewed Jan 4, 2019
View reviewed changes
Copy link

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

tombuildsstuff
tombuildsstuff approved these changes Jan 4, 2019
View reviewed changes
Copy link

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bill-rich bill-rich merged commit 71fd6f1 into master Jan 7, 2019
@bill-rich bill-rich deleted the f-memory-reservation-locked-to-max branch January 7, 2019 20:53
@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
size/s Relative Sizing: Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't create new VM without specifying valid value for memory_reservation parameter
2 participants
@bill-rich @tombuildsstuff