Bugfix for #23004

[alex-harvey-z3q]

Before this, the Terraform Puppet provisioner would error out in a
confusing way if the type attribute in a connection block was not given.

Apparently an omitted type leads to type having a value "" which must be
then assumed to mean "ssh".

[alex-harvey-z3q]

@mildwonkey @rodjek

[mildwonkey]

I left one question in-line, but in general this LGTM!

[mildwonkey]

This looks great @alexharv074 ! I'm going to give @rodjek a little time to review this, but if we don't hear anything in a week or so (before the next release) I'll approve and merge.

[alex-harvey-z3q]

@mildwonkey further to my update yesterday, I found Tim's code and I saw how he was testing on Windows and set it all up and it's tested now on Windows. But the logic to provide feedback if password is absent didn't achieve anything. In fact, if password is empty, the Windows agent node hangs forever by the looks of it and never reaches my patch code--or maybe it eventually provides feedback after a 15 minute timeout. I wasn't patient enough to wait! Suffice to say I think error handling is needed somewhere to detect early that a user missed the password but it shouldn't be implemented in my bugfix.

Whenever you and Tim are happy, I'm ok for you to merge this.

[mildwonkey]

I'll make sure this gets merged by the end of this week - thanks @alexharv074 ! I'm impressed with your follow-up 🎉

[mildwonkey]

🎉

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.