Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix tests #308

Open
idontgetoutmuch opened this issue Jul 1, 2019 · 3 comments
Open

fix tests #308

idontgetoutmuch opened this issue Jul 1, 2019 · 3 comments

Comments

@idontgetoutmuch
Copy link
Member

idontgetoutmuch commented Jul 1, 2019

We still get random failures despite commenting out the more susceptible tests. I think this is easy to fix: we just check we are using sensible matrices in the tests (ones that are not too close to being singular).

See also #259 #145 #19 (maybe)

@dpaetzel
Copy link

Hi! How close do you mean by “not too close to being singular”? I ran into issues with singular matrices in hmatrix that I can't quite tie to the algorithm I'm using—could this be due to numeric instabilities? Is there some threshold I could use to debug whether this is the problem I'm seeing?

@idontgetoutmuch
Copy link
Member Author

You can use https://hackage.haskell.org/package/hmatrix-0.20.0.0/docs/Numeric-LinearAlgebra.html#g:18 rcond to find the reciprocal of condition number: https://en.wikipedia.org/wiki/Condition_number. My idea is to test only matrices for which this is smaller than machine precision.

@dpaetzel
Copy link

Sounds sensible, I’ll give it a try. Thank you! 🙂

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants