Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Releasing Servant 0.20.3.0 #1807

Open
tchoutri opened this issue Mar 5, 2025 · 5 comments
Open

Releasing Servant 0.20.3.0 #1807

tchoutri opened this issue Mar 5, 2025 · 5 comments

Comments

@tchoutri
Copy link
Contributor

tchoutri commented Mar 5, 2025

At the moment we have a nice collection of PRs that have landed which should not break the API. I suggest that we bump the minor version of the libraries to 0.20.3.0.

Let's open the window for merging bug fixes.

cc @fisx @ysangkok @maksbotan @gdeest Are there things you'd like to see merged?

@tchoutri tchoutri moved this to In progress in Servant 0.20.3.0 Mar 5, 2025
@gdeest
Copy link
Contributor

gdeest commented Mar 5, 2025

@tchoutri I don't, but let me add that I am quite looking forward to the inclusion of MultiVerb into an official release.

@tchoutri
Copy link
Contributor Author

tchoutri commented Mar 5, 2025

@gdeest Cheers! If you could take some time to try it out, I'd be very happy (replacing UVerb would be even better but even for new endpoints it'd already be very useful)!

You can see how it went for me in https://github.com/flora-pm/flora-server/pull/824/files

@gdeest
Copy link
Contributor

gdeest commented Mar 5, 2025

Nice ! (At the risk of totally derailing this discussion, I would expect the derivation of AsUnion to be fully automated ; is there something that prevents you from using the deriving via GenericAsUnion machinery mentioned in the documentation ?)

@tchoutri
Copy link
Contributor Author

tchoutri commented Mar 5, 2025

@gdeest Missing instance:

src/web/FloraWeb/Pages/Routes/Settings.hs:58:13: error: [GHC-39999]
    • No instance for ‘AsConstructor
                         '[Text]
                         (WithHeaders
                            '[Header "Location" Text] ((), Text) (RespondEmpty 301 ""))’
        arising from the 'deriving' clause of a data type declaration

I'm thinking of adding it in Servant so that can be of use to others.

@tchoutri
Copy link
Contributor Author

tchoutri commented Mar 5, 2025

@gdeest Turns out I was making my own life more difficult, what Servant provides in bce6b4b is more than enough. See flora-pm/flora-server@f2aeadd#diff-6f785d339b724305d4914914a6604755232ecb2c97631f5be1b5427206fe531f

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

2 participants