Merge branch 'master' into 2021-12-21-ci-fxs

Author: Anton-Latukha

.github/ISSUE_TEMPLATE/bug_report.md

@@ -8,17 +8,19 @@ assignees: ''
 ---
 
 <!--
-Before opening an issue, please take a look at the [troubleshooting guide](https://haskell-language-server.readthedocs.io/en/latest/troubleshooting.html). This explains some common issues and will also help you to find the information that the issue template asks for.
+Before opening an issue, please take a look at the [troubleshooting guide](https://haskell-language-server.readthedocs.io/en/latest/troubleshooting.html).
+This explains some common issues and will also help you to find the information that the issue template asks for.
 
-When filing an issue, please fill out as much of the information below as you can. This helps us to debug your issue, but is not required!
+When filing an issue, please fill out as much of the information below as you can.
+This helps us to debug your issue, but is not required!
 -->
 
 ### Your environment
 
 Which OS do you use:
 <!-- Windows, MacOS, Ubuntu, ArchLinux, etc... -->
-Which lsp-client do you use:
-<!-- Neovim, emacs, VS Codium, etc... -->
+Which LSP client (editor/plugin) do you use:
+<!-- Neovim+LanguageClient-neovim, emacs+lsp-mode, VS Codium+vscode-haskell, etc... -->
 Describe your project (alternative: link to the project):
 <!-- stack.yaml, package.yaml, *.cabal files, cabal.project, hie.yaml -->
 
@@ -32,26 +34,5 @@ Describe your project (alternative: link to the project):
 <!-- Tell us what happens instead. -->
 
 ### Include debug information
-Execute in the root of your project the command `haskell-language-server-wrapper --debug .` and paste the logs here:
-(if you are using the vscode extension check the executable location [here](https://github.com/haskell/vscode-haskell#downloaded-binaries))
-<details>
-<summary>
-Debug output:
-</summary>
-
-```
-<paste your logs here>
-```
-</details>
-
-Paste the logs from the lsp-client, you can check instructions about for VS Code [here](https://github.com/haskell/vscode-haskell#troubleshooting)
-
-<details>
-<summary>
-LSP logs:
-</summary>
-
-```
-<paste your logs here>
-```
-</details>
+
+<!-- Include any useful debug information, such as relevant log snippets. -->

docs/conf.py

@@ -57,7 +57,8 @@
 # ones.
 extensions = [
     'myst_parser',
-    'sphinx_rtd_theme'
+    'sphinx_rtd_theme',
+    'sphinx.ext.autosectionlabel'
 ]
 
 # Add any paths that contain templates here, relative to this directory.

docs/index.rst

@@ -1,11 +1,12 @@
 haskell-language-server
 =======================
 
-Official haskell ide support via language server (LSP). Successor of `ghcide <https://github.com/haskell/ghcide>`_ and `haskell-ide-engine <https://github.com/haskell/haskell-ide-engine>`_. Read the `project's background <https://neilmitchell.blogspot.com/2020/01/one-haskell-ide-to-rule-them-all.html>`_.
+Official Haskell Language Server implementation. :ref:`Read more<What is haskell-language-server?>`.
 
 .. toctree::
    :maxdepth: 2
 
+   what-is-hls
    features
    installation
    supported-versions

docs/installation.md

@@ -39,6 +39,8 @@ choco install haskell-language-server
 
 If you are using Visual Studio Code, the [Haskell extension](https://marketplace.visualstudio.com/items?itemName=haskell.haskell) will automatically download and install `haskell-language-server` for you.
 
+If you need to find the binaries, please consult the [documentation](https://github.com/haskell/vscode-haskell#downloaded-binaries) for the extension.
+
 ## Pre-built binaries
 
 There are pre-built binaries available from the [releases page](https://github.com/haskell/haskell-language-server/releases) for Linux, Windows and macOS.

docs/troubleshooting.md

@@ -1,79 +1,190 @@
 # Troubleshooting
 
-## Known limitations
+## Help, I have no idea what these words mean
 
-### Limited GHC 9 Support
-Currently, GHC 9 support in HLS is in beta stage; some features are unavailable with GHC >= 9.0.1 for the time being.
-This situation is expected to be resolved in the near future after all the dependent packages support GHC 9.
-See issue [#297](https://github.com/haskell/haskell-language-server/issues/297) for the supported features in GHC 9 and the status of migration progress.
+If you are new to the project, you may find it helpful to read the [introduction](./what-is-hls.md) page, which explains some of the terminology used on this page.
 
-### Preprocessor
-HLS is not yet able to find project preprocessors, which may result in `could not execute: <preprocessor>` errors. This problem is
-tracked in https://github.com/haskell/haskell-language-server/issues/176 and originally comes from https://github.com/mpickering/hie-bios/issues/125
+## Getting help
 
-As a workaround, you need to ensure the preprocessor is available in the path (install globally with Stack or Cabal, provide in `shell.nix`, etc.).
+### Where to ask
 
-Example with `tasty-discover`:
+Many of the developers are active on [IRC](https://web.libera.chat/?channels=#haskell-language-server).
+However, the most direct way to get help is to open an [issue](https://github.com/haskell/haskell-language-server/issues).
 
-```haskell
-{-# OPTIONS_GHC -F -pgmF tasty-discover #-}
-```
+If you can diagnose whether a problem is with HLS or with the client that you are using, then it is helpful to open an issue in the appropriate repository.
+But this can be tricky, and if you're not sure then you can always open one in the HLS repository and we'll help you figure out what's going on.
 
-This returns an error in HLS if 'tasty-discover' is not in the path: `could not execute: tasty-discover`.
+### What to include
 
-### Problems with multi component (tests suites, executables, benchmarks) support using stack
+Please try and give us as much information as you can!
+In particular, the more you can diagnose the problem, the better.
 
-Due to some limitations in the interaction between HLS and stack, there are some issues in projects with a main library and executables, test suites or benchmarks:
-- The stack project has to be built succesfully *before* loading it with HLS to get components other than the library work.
-- Changes in the library are not automatically propagated to other components, especially in the presence of errors in the library, so you have to restart HLS to get those components correctly loaded. The usual symptom is the editor showing errors like `Could not load module ...` or `Cannot satisfy -package ...`
-- See https://github.com/haskell/haskell-language-server/issues/366 for more info about.
-## Common issues
+## Basic diagnosis steps
 
-### Problems with dynamic linking
+This section lists a few basic diagnostic steps that are almost always helpful.
 
-As haskell-language-server prebuilt binaries are statically linked, they don't play well with projects using dynamic linking.
-An usual symptom is the presence of errors containing `unknown symbol` and it is typical in arch linux, where a dynamically linked version of ghc is used.
+Sometimes these checks may be enough to work out where the problem is.
+If not, refer to the sections below about diagnosing problems with the server and client, respectively.
+That will also require you to figure out is whether you are looking at an issue with the server or the client.
+This can be tricky to work out: if in doubt, open an issue and we'll help you figure it out.
 
-The workaround is to use a version of haskell-language-server compiled from source with the ghc option `-dynamic` enabled. See more details [here](https://github.com/haskell/haskell-language-server/issues/1160#issuecomment-756566273).
+Typical examples of client issues:
+- The wrong server binary is being launched
+- Diagnostics are being shown in the wrong place
 
-### Support for Template Haskell
+Typical examples of server issues:
+- The server crashes on certain files
+- A code action doesn't work the way it's supposed to
 
-Template Haskell should work fine in Linux and Windows with the distributed binaries. In Mac Os a dynamically linked binary of HLS is required to avoid segmentation faults. The easiest way to obtain a dynamically linked HLS binary is to build it locally. With cabal install this can be done as follows:
+Unclear examples:
+- Hover documentation looks wrong (the client might be rendering it wrong, or the server might be sending the wrong thing)
+- Missing functionality (the client might not support it, or the server might not support it)
 
-    cabal update && cabal install haskell-language-server --enable-executable-dynamic
+### Finding your `haskell-language-server` binary
+
+Several of the diagnostic steps require you to run the actual `haskell-language-server` binary that is installed on your computer.
+
+Where the binary is will depend on how you installed HLS.
+Consult the [installation](./installation.md) page for help.
+
+As usual, if you installed HLS with the wrapper, you will want to run `haskell-language-server-wrapper` instead.
+
+### Getting basic information about your installation
+
+Running `haskell-language-server --probe-tools` will produce useful information, such as the version of HLS that you are using.
+Including this in issue reports is helpful.
+
+### Checking that the server is running
+
+If the server isn't running at all when you are editing a Haskell file in your project, then that suggests that the client is having difficulty launching it.
+Often this means that the client is configured to run the wrong binary, or the correct one is not available in your `PATH`.
+
+The easiest way to check whether the server is running is to use an OS process monitor to see if there is a `haskell-language-server` process running.
+
+### Checking whether the client is connecting to the server
 
-## Troubleshooting the server
+If the server is running, you should see some kind of indicator in your client.
+In some clients (e.g. `coc`) you may need to run a command to query the client's beliefs about the server state.
+If the client doesn't seem to be connected despite the server running, this may indicate a bug in the client or HLS.
 
-### Diagnostic mode
+### Checking whether the project is being built correctly by HLS
 
-The `haskell-language-server` executable can be run in diagnostic mode, where it will just try to load modules from your project, printing all of its output to stdout.
-This makes it much easier to see what's going on and to diagnose build-related problems.
+HLS needs to build the project correctly, with the correct flags, and if it does not do so then very little is likely to work.
+A typical symptom of this going wrong is "incorrect" compilation errors being sent to the client.
 
-To do this, simply run the executable directly from your shell in the project root.
-You can either run it without an argument, in which case it will load random modules, or with a path, in which case it will load modules in that file or directory.
+If this is happening, then it usually indicates a problem in the server's configuration.
 
-### Examining the log
+### Checking whether basic functionality is working
+
+If everything otherwise seems to be fine, then it is useful to check whether basic functionality is working.
+Hover documentation (at least including type signatures) is usually a good one to try.
+
+### Identifying specific files that cause problems
+
+If possible, identifying specific files that cause problems is helpful.
+If you want to be really helpful, minimising the example can really speed up diagnosis.
+
+## Diagnosing problems with the server
+
+### Examining the server log
 
 Most clients will launch `haskell-language-server` with `--logfile` to make it write a log file.
 Please consult the documentation for your client to find out where this is (or how to set it).
 
 The log will contain all the messages that are sent to the server and its responses.
-This is helpful for low-level debugging: if you expect a certain action to happen, you can look in the log to see if the corresponding messages are
-sent, or if there are any errors.
+This is helpful for low-level debugging: if you expect a certain action to happen, you can look in the log to see if the corresponding messages are sent, or if there are any errors.
+
+To get a more verbose log, you can also pass the `--debug` argument to the server.
+
+### Reproducing failures on the command-line
+
+The `haskell-language-server` binary can be run from the command line.
 
-To get a more verbose, also pass `--debug` to the executable.
+If it is run with a specific file as an argument, it will try and load that file specifically.
+If it is run without a specific file, it will try and load all the files in the project.
 
-### Identify which plugin could be the cause of the issue.
+If you are having trouble loading one or many files in the editor, then testing it this way can help make the failure more obvious and reproducible.
 
-Sometimes the issue is produced by one of the plugins included in HLS. To diagnose that and help to trace the final cause one possible strategy is simple disable all plugins, check if the issue is gone and then enable them selectively until the issue is reproduced again.
+Running HLS from the command-line directly also provides an easy way to get the logs (with or without `--debug`).
 
-There is a configuration json snippet which disables all plugins [here](https://github.com/haskell/haskell-language-server/issues/2151#issuecomment-911397030).
+### Plugin-related issues
 
-## Troubleshooting the client
+Sometimes the issue is related to one of HLS's plugins.
+One strategy for diagnosing this is simply disable all plugins, check if the issue is gone and then enable them selectively until the issue is reproduced again.
+
+There is a configuration JSON snippet which disables all plugins [here](https://github.com/haskell/haskell-language-server/issues/2151#issuecomment-911397030).
+
+## Diagnosing problems with the client
+
+The most important thing to do is to consult the client's documentation.
+Usually this will provide some information about troubleshooting.
+
+For example:
+- `lsp-mode` has a [troubleshooting page](https://emacs-lsp.github.io/lsp-mode/page/troubleshooting/)
+- The VSCode Haskell extension has a [troubleshooting section](https://github.com/haskell/vscode-haskell#investigating-and-reporting-problems)
 
 Many clients provide diagnostic information about a LSP session.
 In particular, look for a way to get the status of the server, the server stderr, or a log of the messages that the client has sent to the server.
-For example, `lsp-mode` provides all of these (see its [troubleshooting page](https://emacs-lsp.github.io/lsp-mode/page/troubleshooting/) for details).
-For vscode you can read how to access the lsp session log [here])https://github.com/haskell/vscode-haskell#investigating-and-reporting-problems).
+
+## Common issues
+
+### Wrong server binary being used
+
+HLS needs to be compiled against the same version of GHC as is used in the project.
+Normally, we ship binaries for multiple versions and `haskell-language-server-wrapper` selects the correct one.
+
+If you see an error about HLS being compiled with the wrong version of GHC, then you either need to install the correct one (if you installed it yourself), or there is something going wrong with the wrapper selecting the right HLS binary to launch.
+
+### Unsupported GHC version
+
+HLS does not support every GHC version - there are a lot of them!
+Please see the [supported versions page](./supported-versions.md) for more information.
+
+In particular, support for GHC 9.0 and 9.2 is only partial; some features are unavailable with GHC >= 9.0.1, and HLS is not available at all for GHC 9.2.
+
+### Missing server or build tools
 
 The most common client-related problem is the client simply not finding the server executable or the tools needed to load Haskell code (`ghc`, `cabal`, or `stack`). So make sure that you have the right `PATH` and you have configured the client to look for the right executables.
+
+Usually this will be visible in the client's log.
+
+### Compilation failures
+
+Sometimes HLS will simply fail to do anything with a file, or give nonsensical error messages.
+The most common cause of this is that HLS is using the wrong `hie-bios` cradle to decide how to build the project (e.g., trying to use `stack` instead of `cabal`).
+The server log will show which cradle is being chosen.
+
+Using an explicit `hie.yaml` to configure the cradle can resolve the problem, see the [configuration page](./configuration.md#configuring-your-project-build).
+
+### Static binaries
+
+Static binaries use the GHC linker for dynamically loading dependencies when typechecking TH code, and this can run into issues when loading shared objects linked against mismatching system libraries, or into GHC linker  bugs (mainly the Mach linker used in Mac OS, but also potentially the ELF linker).
+Dynamically linked binaries (including`ghci`) use the system linker instead of the GHC linker and avoid both issues.
+
+The easiest way to obtain a dynamically linked HLS binary is to build it locally. With `cabal` this can be done as follows:
+
+    cabal update && cabal install haskell-language-server --enable-executable-dynamic
+
+With `stack` you need to manually add the ghc option `-dynamic`.
+
+Note: HLS binaries prior to 1.6.0 were statically linking `glibc` which is not a supported configuration and has been replaced by `musl`.
+
+### Preprocessors
+
+HLS is [not yet](https://github.com/haskell/haskell-language-server/issues/176) able to find project preprocessors, which may result in `could not execute: <preprocessor>` errors.
+
+As a workaround, you can ensure the preprocessor is available in `PATH` (install globally with Stack or Cabal, provide in `shell.nix`, etc.).
+
+Example with `tasty-discover`:
+
+```haskell
+{-# OPTIONS_GHC -F -pgmF tasty-discover #-}
+```
+
+This returns an error in HLS if `tasty-discover`` is not in the path: `could not execute: tasty-discover`.
+
+### Problems with multi component support using stack
+
+Due to some limitations in the interaction between HLS and `stack`, there are [issues](https://github.com/haskell/haskell-language-server/issues/366) in projects with multiple components (i.e. a main library and executables, test suites or benchmarks):
+- The project has to be built succesfully *before* loading it with HLS to get components other than the library work.
+- Changes in the library are not automatically propagated to other components, especially in the presence of errors in the library. So you have to restart HLS in order for those components to be loaded correctly. The usual symptom is the editor showing errors like `Could not load module ...` or `Cannot satisfy -package ...`.