hlints and comments

Author: pepeiborra

ghcide/src/Development/IDE/Core/Compile.hs

@@ -149,7 +149,7 @@ computePackageDeps env pkg = do
 
 typecheckModule :: IdeDefer
                 -> HscEnv
-                -> (ModuleEnv UTCTime) -- ^ linkables not to unload
+                -> ModuleEnv UTCTime -- ^ linkables not to unload
                 -> ParsedModule
                 -> IO (IdeResult TcModuleResult)
 typecheckModule (IdeDefer defer) hsc keep_lbls pm = do
@@ -300,7 +300,11 @@ captureSplicesAndDeps env k = do
             pure $ f aw'
 
 
-tcRnModule :: HscEnv -> ModuleEnv UTCTime -> ParsedModule -> IO TcModuleResult
+tcRnModule
+  :: HscEnv
+  -> ModuleEnv UTCTime -- ^ Program linkables not to unload
+  -> ParsedModule
+  -> IO TcModuleResult
 tcRnModule hsc_env keep_lbls pmod = do
   let ms = pm_mod_summary pmod
       hsc_env_tmp = hscSetFlags (ms_hspp_opts ms) hsc_env
@@ -331,6 +335,7 @@ tcRnModule hsc_env keep_lbls pmod = do
                                              | mod_info <- eltsUDFM $ udfmIntersectUFM hpt (getUniqSet new)]
 
       -- The linkables we depend on at runtime are the transitive closure of 'mods'
+      -- restricted to the home package
       mod_env = filterModuleEnv (\m _ -> elementOfUniqSet (moduleName m) mods_transitive) keep_lbls -- Could use restrictKeys if the constructors were exported
 
       -- Serialize mod_env so we can read it from the interface
@@ -1128,7 +1133,7 @@ loadInterface session ms linkableNeeded RecompilationInfo{..} = do
                 Just (VFSVersion _) -> error "object code in vfs"
 
     let do_regenerate _reason = withTrace "regenerate interface" $ \setTag -> do
-          setTag "Module" $ moduleNameString $ moduleName $ mod
+          setTag "Module" $ moduleNameString $ moduleName mod
           setTag "Reason" $ showReason _reason
           liftIO $ traceMarkerIO $ "regenerate interface " ++ show (moduleNameString $ moduleName mod, showReason _reason)
           regenerate linkableNeeded

ghcide/src/Development/IDE/Core/Rules.hs

@@ -689,8 +689,7 @@ typeCheckRuleDefinition hsc pm = do
 currentLinkables :: Action (ModuleEnv UTCTime)
 currentLinkables = do
     compiledLinkables <- getCompiledLinkables <$> getIdeGlobalAction
-    hm <- liftIO $ readVar compiledLinkables
-    pure hm
+    liftIO $ readVar compiledLinkables
 
 loadGhcSession :: Recorder (WithPriority Log) -> GhcSessionDepsConfig -> Rules ()
 loadGhcSession recorder ghcSessionDepsConfig = do