CI: caching: fix early termination expression check & cabal.project replacement (#2520)

* CI: caching: fix early termination expression check

It is obscure bug.

Details are in
https://matrix.to/#/!oOjZFsoNYPAbTEgSOA:libera.chat/$tB_L6wbaxe1ElQtYzMI9woID4hZyscS6Rhpn-nsCc6Y?via=libera.chat&via=matrix.org&via=monoid.al

Because after the second path somehow it always returned `False` - the caching
runs always resulted in early termination.

* CI: caching: fx `cabal.project` copying

In the
https://github.com/haskell/haskell-language-server/runs/4596861600?check_suite_focus=true
of
#2503

Noted that:

I rm cabal.project. The sources of cabal-ghc921.project contain:
index-state: 2021-12-18T00:00:07Z
cp cabal-ghc921.project cabal.project
Then from cabal.project CI retrieves finderprint 2021-11-29T08:11:08Z.
Seems like GitHub uses alias cp=cp -i - preventing UNIX-like default copying over behaviour.
& rm cabal.project does not remove the file.
cabal.project seems to be protected from deletion.

* cabal*.project: index-state +1s

Renewing cache.

* CI: {caching,test}: make rm/cp comment more informative

* CI: {caching,test}: upd commets

This should short-cirquit.

* cabal*.project: index-state +1s

* Correct small typo

Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Author: 3 people

.github/workflows/caching.yml

@@ -100,7 +100,11 @@ jobs:
       - if: matrix.ghc == '9.0.1'
         name: (GHC 9.0.1) Use modified `cabal.project`
         run: |
-          cp cabal-ghc901.project cabal.project
+          # File has some protections preventing regular `rm`.
+          # (most probably sticky bit is set on $HOME)
+          # `&&` insures `rm -f` return is positive.
+          # Many platforms also have `alias cp='cp -i'`.
+          rm -f -v cabal.project && cp -v cabal-ghc901.project cabal.project
       - if: runner.os == 'Windows' && matrix.ghc == '8.8.4'
         name: (Windows,GHC 8.8) Modify `cabal.project` to workaround segfaults
         run: |
@@ -154,11 +158,11 @@ jobs:
                 ${{ env.cache-name }}-${{ runner.os }}-${{ matrix.ghc }}-
                 ${{ env.cache-name }}-${{ runner.os }}-
 
-      - if: (! steps.compiled-deps.outputs.cache-hit)
+      - if: steps.compiled-deps.outputs.cache-hit != 'true'
         run: |
           cabal update
 
-      - if: (! steps.compiled-deps.outputs.cache-hit)
+      - if: steps.compiled-deps.outputs.cache-hit != 'true'
         name: Download all sources
         run: |
           cabal $cabalBuild --only-download
@@ -168,7 +172,7 @@ jobs:
       # but to cache what can be cached, so step is fault tolerant & would always succseed.
       # 2021-12-11: NOTE: Building all targets, since
       # current Cabal does not allow `all --enable-tests --enable-benchmarks --only-dependencies`
-      - if: (! steps.compiled-deps.outputs.cache-hit)
+      - if: steps.compiled-deps.outputs.cache-hit != 'true'
         name: Build all targets; try 3 times
         continue-on-error: true
         run: |

.github/workflows/test.yml

@@ -95,7 +95,11 @@ jobs:
       - if: matrix.ghc == '9.0.1'
         name: (GHC 9.0.1) Use modified `cabal.project`
         run: |
-          cp cabal-ghc901.project cabal.project
+          # File has some protections preventing regular `rm`.
+          # (most probably sticky bit is set on $HOME)
+          # `&&` insures `rm -f` return is positive.
+          # Many platforms aslo have `alias cp='cp -i'`.
+          rm -f -v cabal.project && cp -v cabal-ghc901.project cabal.project
       - if: runner.os == 'Windows' && matrix.ghc == '8.8.4'
         name: (Windows,GHC 8.8) Modify `cabal.project` to workaround segfaults
         run: |

cabal-ghc901.project

@@ -37,7 +37,7 @@ package *
 
 write-ghc-environment-files: never
 
-index-state: 2021-11-29T12:30:08Z
+index-state: 2021-11-29T12:30:10Z
 
 constraints:
   -- These plugins don't work on GHC9 yet

cabal-ghc921.project

@@ -36,7 +36,7 @@ package *
 
 write-ghc-environment-files: never
 
-index-state: 2021-11-29T12:30:08Z
+index-state: 2021-11-29T12:30:10Z
 
 constraints:
   -- These plugins doesn't work on GHC92 yet

cabal.project

@@ -40,7 +40,7 @@ package *
 
 write-ghc-environment-files: never
 
-index-state: 2021-11-29T12:30:08Z
+index-state: 2021-11-29T12:30:10Z
 
 constraints:
     hyphenation +embed