Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Wingman: empty case code lens spurious appears for genuine empty-cases #1960

Closed
isovector opened this issue Jun 22, 2021 · 0 comments · Fixed by #1962
Closed

Wingman: empty case code lens spurious appears for genuine empty-cases #1960

isovector opened this issue Jun 22, 2021 · 0 comments · Fixed by #1962
Labels
component: wingman type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@isovector
Copy link
Collaborator 

absurd :: Void -> a
absurd v = case v of

has a Case split (Void) code action, but it shouldn't because there are actually no constructors here that can typecheck. This is an extremely easy fix, to just check not . null . tacticsGetDataCons before emitting the code lens.
@isovector isovector added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. good first issue component: wingman labels Jun 22, 2021
@isovector isovector mentioned this issue Jun 22, 2021
Merged
@mergify mergify bot closed this as completed in #1962 Jun 25, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
component: wingman type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
1 participant
@isovector