From 68205c3c5e9323ba9fb4a44d5bb70ceeb3c4e686 Mon Sep 17 00:00:00 2001 From: Pepe Iborra Date: Sun, 23 Jan 2022 10:42:32 +0000 Subject: [PATCH] Drop bytestring-encoding --- ghcide/ghcide.cabal | 1 - ghcide/src/Development/IDE/Core/Rules.hs | 8 +++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/ghcide/ghcide.cabal b/ghcide/ghcide.cabal index 57976ef2d4..163fd9e678 100644 --- a/ghcide/ghcide.cabal +++ b/ghcide/ghcide.cabal @@ -95,7 +95,6 @@ library hslogger, Diff ^>=0.4.0, vector, - bytestring-encoding, opentelemetry >=0.6.1, heapsize ==0.3.*, unliftio, diff --git a/ghcide/src/Development/IDE/Core/Rules.hs b/ghcide/src/Development/IDE/Core/Rules.hs index 8c601917a2..47ee55c32d 100644 --- a/ghcide/src/Development/IDE/Core/Rules.hs +++ b/ghcide/src/Development/IDE/Core/Rules.hs @@ -76,7 +76,6 @@ import Data.Aeson (Result (Success), import qualified Data.Aeson.Types as A import qualified Data.Binary as B import qualified Data.ByteString as BS -import Data.ByteString.Encoding as T import qualified Data.ByteString.Lazy as LBS import Data.Coerce import Data.Foldable @@ -92,6 +91,7 @@ import Data.Maybe import qualified Data.Rope.UTF16 as Rope import qualified Data.Set as Set import qualified Data.Text as T +import qualified Data.Text.IO as T import qualified Data.Text.Encoding as T import Data.Time (UTCTime (..)) import Data.Tuple.Extra @@ -130,7 +130,6 @@ import Development.IDE.Types.Location import qualified Development.IDE.Types.Logger as L import Development.IDE.Types.Options import GHC.Generics (Generic) -import GHC.IO.Encoding import qualified GHC.LanguageExtensions as LangExt import qualified HieDb import Ide.Plugin.Config @@ -526,14 +525,13 @@ persistentHieFileRule :: Rules () persistentHieFileRule = addPersistentRule GetHieAst $ \file -> runMaybeT $ do res <- readHieFileForSrcFromDisk file vfs <- asks vfs - encoding <- liftIO getLocaleEncoding (currentSource,ver) <- liftIO $ do mvf <- getVirtualFile vfs $ filePathToUri' file case mvf of - Nothing -> (,Nothing) . T.decode encoding <$> BS.readFile (fromNormalizedFilePath file) + Nothing -> (,Nothing) <$> T.readFile (fromNormalizedFilePath file) Just vf -> pure (Rope.toText $ _text vf, Just $ _lsp_version vf) let refmap = Compat.generateReferencesMap . Compat.getAsts . Compat.hie_asts $ res - del = deltaFromDiff (T.decode encoding $ Compat.hie_hs_src res) currentSource + del = deltaFromDiff (T.decodeUtf8 $ Compat.hie_hs_src res) currentSource pure (HAR (Compat.hie_module res) (Compat.hie_asts res) refmap mempty (HieFromDisk res),del,ver) getHieAstRuleDefinition :: NormalizedFilePath -> HscEnv -> TcModuleResult -> Action (IdeResult HieAstResult)