Skip to content

"Change all occurrences Ctrl+F2" wreaks havoc for some valid symbols #329

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
szabi opened this issue Dec 9, 2020 · 2 comments
Closed

"Change all occurrences Ctrl+F2" wreaks havoc for some valid symbols #329

szabi opened this issue Dec 9, 2020 · 2 comments
Labels
status: need repro type: bug A bug or unintended effect

Comments

@szabi
Copy link

szabi commented Dec 9, 2020

In particular, for symbols with an ' in their name.

If I try to rename someSymbol', it will

  • only make the name editable up to the ', excluding it,
  • if there is another symbol someSymbol in the source, it will be changed as well.

Using ' is not uncommon in Haskell.
@jneira jneira added type: bug A bug or unintended effect status: need repro labels Dec 9, 2020
@iacore
Copy link

iacore commented Apr 15, 2022

Related to #283 .

@fendor
Copy link
Collaborator

fendor commented Dec 5, 2022

Not our responsibility, feature of Haskell Language Server.
However, issue is likely still relevant, but there are a number of issues in the main repo, see https://github.com/haskell/haskell-language-server/issues?q=is%3Aissue+is%3Aopen+label%3A%22component%3A+hls-rename-plugin%22+

@fendor fendor closed this as completed Dec 5, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
status: need repro type: bug A bug or unintended effect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jneira @szabi @fendor @iacore