Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

udd uses deprecated features #113

Open
e-kwsm opened this issue Dec 4, 2024 · 2 comments · May be fixed by #115
Open

udd uses deprecated features #113

e-kwsm opened this issue Dec 4, 2024 · 2 comments · May be fixed by #115

Comments

@e-kwsm
Copy link

e-kwsm commented Dec 4, 2024

udd: 09f9994

$ deno --version
deno 2.1.2 (stable, release, x86_64-unknown-linux-gnu)
v8 13.0.245.12-rusty
typescript 5.6.2
$ deno lint
error[no-deprecated-deno-api]: `Deno.run` was removed in Deno 2. See the Deno 1.x to 2.x Migration Guide for further details: https://docs.deno.com/runtime/reference/migrate_deprecations/
  --> /tmp/deno-udd/main.ts:12:17
   | 
12 |       const p = Deno.run({
   |                 ^^^^^^^^
   = hint: Use `Deno.Command` from https://deno.land/api?s=Deno.Command instead

  docs: https://lint.deno.land/rules/no-deprecated-deno-api


error[no-deprecated-deno-api]: `Deno.run` was removed in Deno 2. See the Deno 1.x to 2.x Migration Guide for further details: https://docs.deno.com/runtime/reference/migrate_deprecations/
  --> /tmp/deno-udd/main.ts:61:19
   | 
61 |   const process = Deno.run({
   |                   ^^^^^^^^
   = hint: Use `Deno.Command` from https://deno.land/api?s=Deno.Command instead

  docs: https://lint.deno.land/rules/no-deprecated-deno-api


Found 2 problems
Checked 12 files
$ deno test --allow-read --allow-write
Check file:///tmp/deno-udd/registry_test.ts
Check file:///tmp/deno-udd/search_test.ts
Check file:///tmp/deno-udd/semver_test.ts
Check file:///tmp/deno-udd/test.ts
error: TS2694 [ERROR]: Namespace 'Deno' has no exported member 'Writer'.
  writer: Deno.Writer;
               ~~~~~~
    at file:///tmp/deno-udd/progress.ts:11:16

TS2694 [ERROR]: Namespace 'Deno' has no exported member 'Writer'.
  constructor(n: number, writer: Deno.Writer = Deno.stdout) {
                                      ~~~~~~
    at file:///tmp/deno-udd/progress.ts:13:39

TS4114 [ERROR]: This member must have an 'override' modifier because it overrides a member in the base class 'Progress'.
  async log(_: string) {}
        ~~~
    at file:///tmp/deno-udd/progress.ts:26:9

TS4114 [ERROR]: This member must have an 'override' modifier because it overrides a member in the base class 'DenoLand'.
  async all(): Promise<string[]> {
        ~~~
    at file:///tmp/deno-udd/test_deps.ts:37:9

Found 4 errors.
@e-kwsm
Copy link
Author

e-kwsm commented Dec 4, 2024

https://lint.deno.land/rules/no-deprecated-deno-api

  • Deno.run is deprecated since v1.31
  • Deno.Writer deprecated since v1.39

@e-kwsm e-kwsm changed the title migration to deno 2 udd uses deprecated features Dec 4, 2024
@e-kwsm e-kwsm linked a pull request Dec 4, 2024 that will close this issue
@e-kwsm
Copy link
Author

e-kwsm commented Dec 9, 2024

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant