Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable React next versions #80

Open
oscarotero opened this issue May 28, 2022 · 2 comments
Open

Disable React next versions #80

oscarotero opened this issue May 28, 2022 · 2 comments

Comments

@oscarotero
Copy link
Contributor

Hi. When I run udd to update my dependencies, it always update the react version to the "next" version:

https://esm.sh/react@18.1.0 18.1.0 -> 18.2.0-next-e531a4a62-20220505

I guess this is a bug because I would expect to update always to the latest stable version. The other development versions should be ignored.

imaxe

@hayd
Copy link
Owner

hayd commented May 30, 2022

Thanks! Potentially we should ignore the strings: rc, beta, experimental and next...

above here:

deno-udd/mod.ts

Lines 86 to 87 in 19adffa

// for now, let's pick the most recent!
let newVersion = versions[0];

I suppose the clever thing to do is if initVersion included one of those (e.g. rc) then we'd pick the latest that's matches that (also has rc) i.e. do something like versions = allowableVersions(initVersion, versions) above this. wdyt?

(Note: the fragment handling below is a little wild... so we'd need to modify versions array.)

@oscarotero
Copy link
Contributor Author

Yes, it makes sense.
An even more clever behavior could be to sort these fragments by "stability". For example, to update from an alpha version to a beta or rc version. But I'm not sure this can work fine for all cases.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants