From 1bc0b4e1597006284f75fdc42e1f982c69eaad3a Mon Sep 17 00:00:00 2001 From: davidsarosap <147051848+davidsarosap@users.noreply.github.com> Date: Fri, 1 Mar 2024 09:18:29 +0100 Subject: [PATCH] Removing override of a method with a default implementation. (#227) The word "Default" in the "DefaultSchemasCallback.java" let me assume that I can derive classes from it to implement some method which are needed in my use case. The fact that getAttribute is overridden in the DefaultSchemasCallback.java leads to confusion and makes it even harder to make it work with a derived class. I think it is better to just let the default method in the interface shining through. Co-authored-by: Hristo Borisov (cherry picked from commit 81fd5ffbaa85d2cfc704121a15dce299abfc3848) --- .../scimono/callback/schemas/DefaultSchemasCallback.java | 6 ------ 1 file changed, 6 deletions(-) diff --git a/scimono-server/src/main/java/com/sap/scimono/callback/schemas/DefaultSchemasCallback.java b/scimono-server/src/main/java/com/sap/scimono/callback/schemas/DefaultSchemasCallback.java index 01f8346..f128d69 100644 --- a/scimono-server/src/main/java/com/sap/scimono/callback/schemas/DefaultSchemasCallback.java +++ b/scimono-server/src/main/java/com/sap/scimono/callback/schemas/DefaultSchemasCallback.java @@ -4,7 +4,6 @@ import jakarta.ws.rs.WebApplicationException; import jakarta.ws.rs.core.Response; -import com.sap.scimono.entity.schema.Attribute; import com.sap.scimono.entity.schema.Schema; import java.util.List; @@ -37,9 +36,4 @@ public boolean isValidSchemaName(String schemaName) { throw new WebApplicationException(Response.Status.NOT_IMPLEMENTED); } - @Override - public Attribute getAttribute(String path) { - throw new WebApplicationException(Response.Status.NOT_IMPLEMENTED); - } - }