Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

devise errors too hard to style #3832

Closed
Tectract opened this issue Nov 23, 2015 · 9 comments
Closed

devise errors too hard to style #3832

Tectract opened this issue Nov 23, 2015 · 9 comments

Comments

@Tectract
Copy link

Don't have hours to figure this out, don't wan't the crappy default error message styles on my nice site.

@lucasmazza
Copy link
Contributor

As stated in the docs, we recommend you to write your own helpers/markup in case you need any customization of the error message.

@Tectract
Copy link
Author

That is far, far too hard for any laymen to figure out, or even find. It should be easy to customize error messages, not insanely, insanely hard. This ticket should be re-opened. I specifically went looking for that info in the docs and I didn't find it. And your link doesn't link to docs either, it links to source code with no explanation of what to do with it.

@josevalim
Copy link
Contributor

@Tectract at the end of devise:install, we now ask users to copy the views to their application. If you do it, you can just go and change the view.

That is far, far too hard for any laymen to figure out, or even find. It should be easy to customize error messages, not insanely, insanely hard.

Thanks for the feedback. We will keep an eye on it and see if others have the same complaint so we can take the best action.

@josevalim
Copy link
Contributor

Also, if you don't have hours to figure something out, it is ultimately your fault. Not ours. Be nice, we are always willing to help. It seems we have plenty of material on the topic.

Contributions to continue improving are always welcome.

@Tectract
Copy link
Author

Yeah, that seems like a pretty ridiculous attitude to me. The docs are really flimsy there and referring to SA question thread just exhibits more laziness to me. I think you can judge the quality of a piece of software largely by the documentation, and what I see here is the most half-assed possible effort to document a widely-used feature that is poorly supported, and a defensive attitude to newcomers who don't have time to re-invent the wheel because every damn gem tries to include some shitty styles.

For example:

How do I make it so each possible error message has it's own form and style? Just hack it by trial and error for a few hours I guess. Great.

@josevalim
Copy link
Contributor

We have shown where the documentation exist, because you mentioned there was none, and a couple others link too. We have been open to change and asked for contributions while you have just been rude towards the maintainers of the project which you are using.

If you don't have time to help to contribute, at least be nice. That's the only thing we ask, really.

@Tectract
Copy link
Author

I'm just pointing out that the documentation here is basically little more than a hand-waiving at the source code with no real explanation of how to actually customize the error messages. It needs work. The fact that there are huge long threads of confused people should be your indication that it needs improvement, not content for your FAQ.

@PragTob
Copy link

PragTob commented Nov 23, 2015

@Tectract devise is open source and provided to you free of charge, the people at plataformatec put ridiculous amounts of work into it so you can have a nice standard authentication solution that "just works" (tm). The least you could do in my opinion is show some appreciation for what they do and thank them. Imo in the open source spirit I think it'd be nice for you to help out with the docs. They don't have to, for lots of them it's a free time activity. You could start a bountysource bounty if it is that important to you. The reaction to getting free things should not be "NOW GIVE ME MORE OF THAT" but rather constructive and nice. Also, you don't have to use devise. There are other options out there. You could also roll your own, but I'm sure that'd take more time than adjusting devise error messages.

On that note, thanks @josevalim @lucasmazza and company - have used devise for a variety of projects and it has always been a pleasure and made me develop applications much faster than it'd otherwise have been. ❤️ ❤️ 👍 👍 🚀 💃

Cheers and love,
an open source maintainer

@heartcombo heartcombo locked and limited conversation to collaborators Nov 23, 2015
@josevalim
Copy link
Contributor

Thanks @PragTob. ❤️

PS: I am locking this because comments were being edited. Contributions are always welcome, just please don't expect us to do the work, specially if you start the issue by saying you don't have the time to do it yourself.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

No branches or pull requests

4 participants