Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Open above and below are broken in multi-range selections #12448

Open
dead10ck opened this issue Jan 7, 2025 · 2 comments · May be fixed by #12465
Open

Open above and below are broken in multi-range selections #12448

dead10ck opened this issue Jan 7, 2025 · 2 comments · May be fixed by #12465
Labels
C-bug Category: This is a bug
Milestone
next

Comments

@dead10ck
Copy link
Member

dead10ck commented Jan 7, 2025 •
edited
Loading

Summary

open_above and open_below are both broken on the secondary ranges of a multi-range selection. The secondary cursor ends up on a line above where it should be for both commands. e.g.,

[workspace]
resolver = "2"
members = [
  "#[|h]#elix-core",
  "#(|h)#elix-view",
  "#(|h)#elix-term",
  "helix-tui",
  "helix-lsp-types",
  "helix-lsp",
  "helix-event",
  "helix-dap",
  "helix-loader",
  "helix-vcs",
  "helix-parsec",
  "helix-stdx",
  "xtask",
]

Pressing o becomes:

[workspace]
resolver = "2"
members = [
  "helix-core",
  #[|]#
  "helix-view",#(|)#

  "helix-ter#(|m)#",

  "helix-tui",
  "helix-lsp-types",
  "helix-lsp",
  "helix-event",
  "helix-dap",
  "helix-loader",
  "helix-vcs",
  "helix-parsec",
  "helix-stdx",
  "xtask",
]

and pressing O becomes:

[workspace]
resolver = "2"
members = [
  #[|]#
  "helix-core",#(|)#

  "helix-vie#(|w)#",

  "helix-term",
  "helix-tui",
  "helix-lsp-types",
  "helix-lsp",
  "helix-event",
  "helix-dap",
  "helix-loader",
  "helix-vcs",
  "helix-parsec",
  "helix-stdx",
  "xtask",
]

From a bisect, it looks like the breakage happened in #12215
@dead10ck dead10ck added the C-bug Category: This is a bug label Jan 7, 2025
@RoloEdits
Copy link
Contributor

I thought something seemed off, this was it. I can confirm this behavior too. Thought it was me doing wrong selections, and it ended up wonky because of that.

@TornaxO7
Copy link
Contributor

TornaxO7 commented Jan 7, 2025

Ooof, damn it, sorry.
I can investigate that (and add a test for the future xD).

@archseer archseer added this to the next milestone Jan 8, 2025
TornaxO7 added a commit to TornaxO7/helix that referenced this issue Jan 9, 2025
@TornaxO7
fix helix-editor#12448 and add tests for open_{below, above} with m…
0014a88 
…ultiple cursors
@TornaxO7 TornaxO7 linked a pull request Jan 9, 2025 that will close this issue
Open
TornaxO7 added a commit to TornaxO7/helix that referenced this issue Jan 9, 2025
@TornaxO7
fix helix-editor#12448 and add tests for open_{below, above} with m…
4834cba 
…ultiple cursors
@TornaxO7 TornaxO7 mentioned this issue Jan 9, 2025
Closed
rockboynton pushed a commit to rockboynton/helix that referenced this issue Jan 9, 2025
@TornaxO7
fix helix-editor#12448 and add tests for open_{below, above} with m…
5996711 
…ultiple cursors
rockboynton pushed a commit to rockboynton/helix that referenced this issue Jan 9, 2025
@TornaxO7
fix helix-editor#12448 and add tests for open_{below, above} with m…
e99ad12 
…ultiple cursors
rockboynton pushed a commit to rockboynton/helix that referenced this issue Jan 12, 2025
@TornaxO7
fix helix-editor#12448 and add tests for open_{below, above} with m…
4096c83 
…ultiple cursors
rockboynton pushed a commit to rockboynton/helix that referenced this issue Jan 12, 2025
@TornaxO7
fix helix-editor#12448 and add tests for open_{below, above} with m…
578d8bc 
…ultiple cursors
rockboynton pushed a commit to rockboynton/helix that referenced this issue Jan 12, 2025
@TornaxO7
fix helix-editor#12448 and add tests for open_{below, above} with m…
4969e46 
…ultiple cursors
rockboynton pushed a commit to rockboynton/helix that referenced this issue Jan 12, 2025
@TornaxO7
fix helix-editor#12448 and add tests for open_{below, above} with m…
8117b95 
…ultiple cursors
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug
Projects
None yet
Milestone
next
Development

Successfully merging a pull request may close this issue.

Fix open_{below, above} behaviour with multiple cursors TornaxO7/helix
4 participants
@dead10ck @archseer @RoloEdits @TornaxO7