New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Mouse click on picker are ignored and go to the buffer #12745

Open

howesteve opened this issue Feb 1, 2025 · 1 comment · May be fixed by #12772

howesteve commented Feb 1, 2025

Minor click Helix 25.01.1

Open helix in some random project's folder. Open any file.
Make sure current buffer line is highlighted (i.e. :set cursorline true)
Space + / to open the global search
Enter any random text like ".". Several matching files will be listed in the picker.
Try to click some of the entries from the picker. You'll see actually the buffer behind the picker getting the click event and the current highlighted line behind changes.

Contributor

nik-rev commented Feb 1, 2025

Yeah the picker is currently not handling Event::Mouse:

        let key_event = match event {
            Event::Key(event) => *event,
            Event::Paste(..) => return self.prompt_handle_event(event, ctx),
            Event::Resize(..) => return EventResult::Consumed(None),
            _ => return EventResult::Ignored(None),
        };

as you can see mouse events are ignored. To fix this, MouseEvent should be handled accordingly

renshyle linked a pull request

that will close this issue

add mouse support for the picker #12772

Open

# for free to join this conversation on GitHub. Already have an account? # to comment