Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

nickel: language support (lsp, tree-siiter) #1809

Closed
colemickens opened this issue Mar 14, 2022 · 3 comments · Fixed by #2173
Closed

nickel: language support (lsp, tree-siiter) #1809

colemickens opened this issue Mar 14, 2022 · 3 comments · Fixed by #2173
Labels
A-packaging Area: Packaging and bundling C-enhancement Category: Improvements

Comments

@colemickens
Copy link

Describe your feature request

Hi! Nickel is starting to gain some attention. It would be neat to have support for it in Helix. I haven't looked into this a ton yet, but nickel ships with it's own LSP server, but I opened an issue about a tree-sitter grammar: tweag/nickel#656

I'm not sure if it's possible or makes sense to add support with a tree-sitter grammar?

@colemickens colemickens added the C-enhancement Category: Improvements label Mar 14, 2022
@the-mikedavis
Copy link
Member

Nickel looks pretty cool. They might be able to draw some inspiration from tree-sitter-nix given the similarities in syntax.

Iirc there was some discussion a while back about adding an alternative for syntax highlights that would be simpler to write than a tree-sitter grammar, but in the end I think we prefer to support only tree-sitter since it is possible to build other features on top of it (indents, textobjects, Alt+j/k/h/l motions, eventually folds), and tree-sitter is quite performant compared to some regex-based systems.

@kirawi kirawi added the A-packaging Area: Packaging and bundling label Mar 14, 2022
@colemickens
Copy link
Author

I had a feeling that might be the case and I kind of like it. There's even some discussion on how they're already supporting multiple grammars and I am a big fan of the ecosystem network advantages of investing in LSP/DAP/tree-sitter, etc.

It also seems like someone already hacked on this a bit. Maybe in a few days I can look at this again.

@ErinvanderVeen
Copy link
Contributor

We made https://github.com/nickel-lang/tree-sitter-nickel public.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-packaging Area: Packaging and bundling C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants