Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Slow loading big text file and slow scrolling if more than 10k lines #2074

Closed
thienpow opened this issue Apr 11, 2022 · 11 comments
Closed

Slow loading big text file and slow scrolling if more than 10k lines #2074

thienpow opened this issue Apr 11, 2022 · 11 comments
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug

Comments

@thienpow
Copy link

using latest master branch.

2 problems:

  1. tested to load open json files with more than 10k-30k lines of data. even if it's only 20-30mb
    it's very slow during load, sometime will crash.

  2. loaded, then scroll down and up, if scroll a bit, the scroll seems ok, but if keep scrolling fast, it will hang and jammed....

@the-mikedavis
Copy link
Member

Can you share this large file? Does the log file say anything?

@heliostatic
Copy link
Contributor

heliostatic commented Apr 11, 2022

I went ahead and tried to repro with https://github.com/json-iterator/test-data/blob/master/large-file.json

The log looks like:

2022-04-11T10:54:30.948 helix_view::editor [ERROR] Failed to initialize the LSP for `source.json` { cannot find binary path }
2022-04-11T10:54:30.949 mio::poll [TRACE] registering event source with poller: token=Token(1), interests=READABLE | WRITABLE
2022-04-11T10:54:30.949 mio::poll [TRACE] registering event source with poller: token=Token(2), interests=READABLE | WRITABLE
2022-04-11T10:54:30.949 mio::poll [TRACE] registering event source with poller: token=Token(0), interests=READABLE
2022-04-11T10:54:30.949 mio::poll [TRACE] registering event source with poller: token=Token(1), interests=READABLE
2022-04-11T10:54:39.840 mio::poll [TRACE] deregistering event source from poller
2022-04-11T10:54:39.840 mio::poll [TRACE] deregistering event source from poller

Did find load to be a bit slow, but once open pretty responsive.

@kirawi
Copy link
Member

kirawi commented Apr 11, 2022

Probably a duplicate of #338

@the-mikedavis
Copy link
Member

Copying that big file to a .txt extension makes it fast for me.

As JSON, editing the file is pretty slow (possibly related to #1939) but scrolling around it is very fast.

@kirawi
Copy link
Member

kirawi commented Apr 11, 2022

For big log files, regex based syntax highlighting via plugins would probably be ideal.

@thienpow
Copy link
Author

forgot to mention, the scrolling via Mouse or Touch pad is easily jammed... while scroll via Arrow Key or paging shortcut is fast.

editing is absolutely not feasible in large json... even copy n paste would hang.

@archseer
Copy link
Member

Yeah mouse based scrolling will send a whole bunch of scroll events and each will trigger a re-render.

@archseer
Copy link
Member

I went ahead and tried to repro with https://github.com/json-iterator/test-data/blob/master/large-file.json

Thanks for this, that's a decent file to do measurements on!

@kirawi kirawi closed this as completed Apr 16, 2022
@archseer archseer reopened this Apr 16, 2022
@archseer
Copy link
Member

@kirawi why was this closed?

@kirawi
Copy link
Member

kirawi commented Apr 16, 2022

I thought that the slow scrolling was related to #338 as it sounded like mouse scrolling would trigger highlighting events

@the-mikedavis the-mikedavis added C-bug Category: This is a bug A-helix-term Area: Helix term improvements labels Apr 17, 2022
@kirawi
Copy link
Member

kirawi commented Nov 10, 2022

Closing in favor of #4513 as it's more descriptive of the issue.

@kirawi kirawi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

5 participants