Attempting to replay an empty macro permanently disables the macro register

[PabloMansanet]

Summary

Attempting to replay a macro from a register where one hasn't been recorded yet causes the register to be left in an invalid state, such that no macro can be replayed from it ever again.

This interrelates with #2845 , and it's likely the fix I'm working on will address both.

Reproduction Steps

I tried this:

1. q (I receive a correct error explaining the register is empty)
2. Qihello world<ret>Q (macro is now recorded)
3. q

I expected this to happen: The macro recorded in step 2 is replayed.

Instead, this happened: A spurious error (can't replay because we are already replaying from the same register)

Helix log

No response

Platform

Linux

Terminal Emulator

tmux-256color

Helix Version

22.05-76-g0ad10ce6