Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(types): make Id generic #818

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

Mnigos
Copy link
Contributor

@Mnigos Mnigos commented Aug 15, 2024

Id should have type argument that accepts string literals

closes #817

Id should have type argument that accepts string literals

re hello-pangea#817
Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dnd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 2:53pm

Copy link
Collaborator

@100terres 100terres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 👌

@100terres 100terres merged commit a764bcf into hello-pangea:main Sep 11, 2024
9 of 11 checks passed
@Prains
Copy link

Prains commented Sep 11, 2024

omg just came here looking if library has a maintainer and he closes pr immediately

@100terres
Copy link
Collaborator

@Mnigos your changes are included in the v17.0.0. Thank you again.

@Mnigos
Copy link
Contributor Author

Mnigos commented Sep 16, 2024

@Mnigos your changes are included in the v17.0.0. Thank you again.

That's great to hear!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Generics to DropResult type
3 participants