Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

Faraday deprecation warning #125

Open
mjc-gh opened this issue Dec 24, 2021 · 2 comments
Open

Faraday deprecation warning #125

mjc-gh opened this issue Dec 24, 2021 · 2 comments
Labels
legacy Related to legacy, non-OpenAPI SDK

Comments

@mjc-gh
Copy link

mjc-gh commented Dec 24, 2021

When calling HelloSign.create_embedded_signature_request

I get these log message:

WARNING: `Faraday::Connection#basic_auth` is deprecated; it will be removed in version 2.0.
While initializing your connection, use `#request(:basic_auth, ...)` instead.
See https://lostisland.github.io/faraday/middleware/authentication for more usage info.

I believe it comes from here:

https://github.com/HelloFax/hellosign-ruby-sdk/blob/f5b3cb187873d1be7588c6da775012636f8d90a9/lib/hello_sign/client.rb#L159-L163

However I am not sure how to fix it. Any suggestions?

@aub
Copy link

aub commented Mar 10, 2022

This is because the gem isn't specifying the versions of its dependencies at all. I have a fork over here that fixes this, if that helps.

@aub
Copy link

aub commented Mar 10, 2022

Actually I just made a whole new gem over here. The code is exactly the same as this one except that it includes my two PRs from this repo.

@jtreminio-dropbox jtreminio-dropbox added the legacy Related to legacy, non-OpenAPI SDK label Mar 31, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
legacy Related to legacy, non-OpenAPI SDK
Projects
None yet
Development

No branches or pull requests

3 participants