Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

why was Blacklist support removed? #36

Open
pepijnmm opened this issue May 24, 2023 · 5 comments
Open

why was Blacklist support removed? #36

pepijnmm opened this issue May 24, 2023 · 5 comments
Labels

Comments

@pepijnmm
Copy link

I saw that in commit ccf3a2f
Blacklist started to be removed as an option. and with some commits after that, it got fully hidden as an option with only whitelist remaining.
But I can't find any issue/pr on the reason why. I wanted to use this extension to only enable the proxy on certain websites. So this option would be usefull for me.
Is there a technical reason to not use it?

@Bonjour123
Copy link

Any update ?

@pepijnmm
Copy link
Author

pepijnmm commented Jul 9, 2023

@Bonjour123 As far as I could tell it's because chrome.proxy is now used and that only has a bypass list option.
https://developer.chrome.com/docs/extensions/reference/proxy/
Bypass list: "Individual servers may be excluded from being proxied with the bypassList"
It's not regex sadly.

@henices
Copy link
Owner

henices commented Jul 14, 2023

@Bonjour123 As far as I could tell it's because chrome.proxy is now used and that only has a bypass list option. https://developer.chrome.com/docs/extensions/reference/proxy/ Bypass list: "Individual servers may be excluded from being proxied with the bypassList" It's not regex sadly.

pac script can set proxy only for some domains.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Proxy_servers_and_tunneling/Proxy_Auto-Configuration_PAC_file

@henices
Copy link
Owner

henices commented Jul 14, 2023

I saw that in commit ccf3a2f Blacklist started to be removed as an option. and with some commits after that, it got fully hidden as an option with only whitelist remaining. But I can't find any issue/pr on the reason why. I wanted to use this extension to only enable the proxy on certain websites. So this option would be usefull for me. Is there a technical reason to not use it?

The blacklist UI is a mistake. I did not write any code for the blacklist feature. Ten years ago, all Chrome proxy extensions had bugs, so I wrote my own. I may add Manifest V3 support for this extension in the future.

@pepijnmm
Copy link
Author

pepijnmm commented Jul 14, 2023

Thx henices, I will take a look if I have time soon to see if I I can generate the pac file on the fly to generate the blacklist.
Seems to be possible: https://stackoverflow.com/questions/9022322/using-a-local-proxy-auto-configuration-pac-file-for-proxy-settings-from-a-chr

@henices I already have manifest 3 running on my fork. But I changed how it starts a proxy by moving more stuff to the background js so it won't be a copy paste. Also added a feature that I needed so that I won't be able to access some sites without the proxy on.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants