Use TVReturnType to prevent circular references
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…performance issues.
mskelton
force-pushed
the
fix-editor-perf
branch
from
74dc98d to
35a726c
Compare
mskelton
commented
Apr 26, 2023
| @@ -42,7 +42,7 @@ export declare const cnBase: <T extends CnOptions>(...classes: T) => CnReturn; | |||
| export declare const cn: <T extends CnOptions>(...classes: T) => (config?: TWMConfig) => CnReturn; | |||
|
|
|||
| // compare if the value is true or array of values | |||
| export type isTrueOrArray<T> = T extends true | (infer U)[] ? true : false; | |||
There was a problem hiding this comment.
U wasn't used, so using a simpler unknown[] is fine here.
tianenpang
approved these changes
Apr 29, 2023
There was a problem hiding this comment.
LGTM, this is a huge improvement! Thank you @mskelton 🚀
CC @jrgarciadev
|
Huge thanks! @mskelton 🚀 |
jrgarciadev
approved these changes
Apr 29, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The TypeScript types were behaving very slow and after some digging it was due to a circular reference from
ReturnType<TV>. Swapping that out withTVReturnTypedrastically improves the experience in the editor.There are a bunch of other issues with the types related to missing generic arguments and such that I plan on helping fix in future PRs, but wanted to get this out there since it's a small fix with a big performance improvement.
Additional context
The videos below show the difference in time for errors appearing before and after this change.
Before
Screen.Recording.2023-04-25.at.9.28.41.PM.mov
After
Screen.Recording.2023-04-25.at.9.29.23.PM.mov
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).