Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: improving performance 2 #77

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

Handfish
Copy link
Contributor

@Handfish Handfish commented Jul 5, 2023

Description

#65

Additional context

Use recursion to replace flat.


What is the purpose of this pull request?

Just code golfing performance, inspired by @TIMMLOPK

Original

CVA x 931,787 ops/sec ±0.62% (89 runs sampled)
CVA with tailwind-merge x 503,360 ops/sec ±1.16% (88 runs sampled)
TV with slots x 97,211 ops/sec ±0.44% (91 runs sampled)
TV without slots x 113,086 ops/sec ±0.57% (90 runs sampled)
Fastest is CVA

@TIMMLOPK's branch

CVA x 957,529 ops/sec ±0.54% (90 runs sampled)
CVA with tailwind-merge x 475,375 ops/sec ±1.19% (86 runs sampled)
TV with slots x 151,382 ops/sec ±3.36% (86 runs sampled)
TV without slots x 180,776 ops/sec ±0.53% (88 runs sampled)
Fastest is CVA

This branch

CVA x 940,169 ops/sec ±0.57% (91 runs sampled)
CVA with tailwind-merge x 489,335 ops/sec ±0.79% (90 runs sampled)
TV with slots x 181,157 ops/sec ±0.72% (89 runs sampled)
TV without slots x 210,579 ops/sec ±0.60% (91 runs sampled)
Fastest is CVA
  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the Style Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@jrgarciadev
Copy link
Member

Hey @Handfish could you please update this PR pulling the main changes?

@Handfish
Copy link
Contributor Author

@jrgarciadev Ready to merge

Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements!, thank you @Handfish 🙏🏻

@jrgarciadev jrgarciadev merged commit 53fd2d9 into heroui-inc:main Jul 11, 2023
@depyronick
Copy link

@Handfish awesome job

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants