Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make implied directed edges explicit #23

Open
vincerubinetti opened this issue Jun 27, 2019 · 1 comment
Open

Make implied directed edges explicit #23

vincerubinetti opened this issue Jun 27, 2019 · 1 comment

Comments

@vincerubinetti
Copy link
Collaborator

We talked about this a while ago. I feel that edges that can only be in one direction should be explicitly shown to be directional, like compound -> side effect:
image

Maybe there are database reasons why the direction property should be left "neutral"/undirected for these types of edges, but at least for the front end, I don't see why they shouldn't be shown as arrows.

@dhimmel
Copy link
Member

dhimmel commented Jul 1, 2019

I am starting to come around on this issue. We only use directed metaedges when the source and target metanode are the same, like Gene→regulates→Gene. However, users expect direction when thinking about the relationship between metanodes of different types. I'll have to do a bit of a deep dive into the hetio codebase and past records on this topic to make sure I'm accounting for all of the design decisions.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants