Skip to content

Commit 4e01d90

Browse files
fix(github workflows): fixed to always rely on latest node version number (nodejs/npm vuln)
1 parent f5a8b41 commit 4e01d90

File tree

2 files changed

+28
-31
lines changed

2 files changed

+28
-31
lines changed

.github/workflows/release.yml

+12-12
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,28 @@
11
name: Release
2-
on:
2+
on:
33
# will run for every branch, except tags. See RSRMID-206.
44
push:
55
# Sequence of patterns matched against refs/heads
66
branches:
7-
- "**"
7+
- '**'
88
# Sequence of patterns matched against refs/tags
9-
tags-ignore:
10-
- "**"
9+
tags-ignore:
10+
- '**'
1111
pull_request:
1212
branches:
13-
- "**"
14-
tags-ignore:
15-
- "**"
13+
- '**'
14+
tags-ignore:
15+
- '**'
1616

1717
jobs:
1818
test:
1919
name: Test Job
2020
if: github.event_name == 'pull_request' || (github.event_name == 'push' && github.actor != 'dependabot[bot]')
2121
runs-on: ubuntu-latest
22-
22+
2323
strategy:
2424
matrix:
25-
node-version: ['18', '16', '14']
25+
node-version: ['18', '16']
2626
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
2727

2828
steps:
@@ -37,12 +37,12 @@ jobs:
3737
pip -V
3838
pip install -r requirements.txt
3939
- name: Validate & Coverage Report
40-
run: "./scripts/pep8check.sh"
40+
run: './scripts/pep8check.sh'
4141
- name: Use Node.js ${{ matrix.node-version }}
4242
uses: actions/setup-node@v3
4343
with:
4444
node-version: ${{ matrix.node-version }}
45-
cache: 'npm'
45+
check-latest: true
4646
- name: Install dependencies
4747
run: npm ci
4848
- name: Run test/validation
@@ -66,7 +66,7 @@ jobs:
6666
uses: actions/setup-node@v3
6767
with:
6868
node-version: lts/*
69-
cache: 'npm'
69+
check-latest: true
7070
- name: Install dependencies
7171
run: npm ci
7272
- name: Release

.github/workflows/unicode.yml

+16-19
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,40 @@
11
name: Unicode Version Check
22
on:
33
schedule:
4-
- cron: "0 0 * * *"
5-
4+
- cron: '0 0 * * *'
5+
66
jobs:
77
check:
88
name: Version Check
99
runs-on: ubuntu-latest
1010
steps:
11-
- uses: actions/checkout@v3
12-
- uses: actions/setup-node@v3
13-
with:
14-
node-version: 18
15-
cache: "npm"
16-
- name: Install dependencies
17-
run: npm ci
18-
- run: gulp checkUnicodeVersion
11+
- uses: actions/checkout@v3
12+
- uses: actions/setup-node@v3
13+
with:
14+
node-version: lts/*
15+
check-latest: true
16+
- name: Install dependencies
17+
run: npm ci
18+
- run: gulp checkUnicodeVersion
1919
upgrade:
2020
name: Upgrade Version
2121
runs-on: ubuntu-latest
2222
needs:
2323
- check
2424
if: failure()
2525
steps:
26-
- uses: actions/checkout@v3
26+
- uses: actions/checkout@v3
2727
with:
2828
persist-credentials: false
2929
repository: ${{ github.event.pull_request.head.repo.full_name }}
3030
ref: ${{ github.event.pull_request.head.ref }}
3131
- uses: actions/setup-node@v3
3232
with:
33-
node-version: 18
34-
cache: "npm"
33+
node-version: lts/*
34+
check-latest: true
3535
- uses: actions/setup-python@v3
3636
with:
37-
python-version: "3.x"
37+
python-version: '3.x'
3838
- name: Install dependencies
3939
run: |
4040
pip install --upgrade pip
@@ -46,13 +46,10 @@ jobs:
4646
- name: Create Pull Request
4747
uses: peter-evans/create-pull-request@v4
4848
with:
49-
commit-message: "feat(unicode): upgraded version"
49+
commit-message: 'feat(unicode): upgraded version'
5050
committer: Kai Schwarz <kschwarz@hexonet.net>
5151
branch: upgradeUnicode
5252
base: master
53-
title: "Upgrade Unicode to latest Version"
53+
title: 'Upgrade Unicode to latest Version'
5454
assignees: papakai
5555
reviewers: papakai
56-
57-
58-

0 commit comments

Comments
 (0)