From a16dcb221aa71f8e9922f538ca054a1237ac4c80 Mon Sep 17 00:00:00 2001
From: Peter Barker <pbarker@barker.dropbear.id.au>
Date: Fri, 10 May 2024 12:27:51 +1000
Subject: [PATCH] kmlread: factor checkbox menu items

only difference was checked-or-not
---
 MAVProxy/modules/mavproxy_kmlread.py | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)

diff --git a/MAVProxy/modules/mavproxy_kmlread.py b/MAVProxy/modules/mavproxy_kmlread.py
index fa72af5535..818cf59957 100644
--- a/MAVProxy/modules/mavproxy_kmlread.py
+++ b/MAVProxy/modules/mavproxy_kmlread.py
@@ -392,20 +392,13 @@ def idle_task(self):
                 if layer.key.endswith('-text'):
                     continue
 
-                if layer.key in self.curlayers:
-                    self.menu.items.append(MPMenuCheckbox(
-                        layer.key,
-                        layer.key,
-                        '# kml toggle \"' + layer.key + '\"',
-                        checked=True,
-                    ))
-                else:
-                    self.menu.items.append(MPMenuCheckbox(
-                        layer.key,
-                        layer.key,
-                        '# kml toggle \"' + layer.key + '\"',
-                        checked=False,
-                    ))
+                checked = layer.key in self.curlayers
+                self.menu.items.append(MPMenuCheckbox(
+                    layer.key,
+                    layer.key,
+                    f'# kml toggle \"{layer.key}\"',
+                    checked=checked,
+                ))
             # and add the menu to the map popu menu
             self.module('map').add_menu(self.menu)
         self.menu_needs_refreshing = False