Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Customizing logger function doesn't work, always uses global config logger #75

Closed
Iiiggs opened this issue Nov 2, 2020 · 2 comments · Fixed by #76
Closed

Customizing logger function doesn't work, always uses global config logger #75

Iiiggs opened this issue Nov 2, 2020 · 2 comments · Fixed by #76

Comments

@Iiiggs
Copy link

Iiiggs commented Nov 2, 2020

printLog only knows about global configs:

function printLog (text: string) {
    getGlobalConfig().logger(text);
}

need to have it merge with provided config overrides

@gurisko
Copy link
Contributor

gurisko commented Nov 2, 2020

That's a good catch. I opened a PR that should be fixing this. It seems like this deserves a minor release. What are your thoughts @hg-pyun ?

@hg-pyun
Copy link
Owner

hg-pyun commented Nov 9, 2020

@gurisko @liiggs Thank you for catch!, I will review your pull request soon.

@hg-pyun hg-pyun mentioned this issue Nov 13, 2020
8 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants