Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.

Write tests for __Private\Resolution\resolve_function() #275

Open
lexidor opened this issue Mar 14, 2020 · 1 comment
Open

Write tests for __Private\Resolution\resolve_function() #275

lexidor opened this issue Mar 14, 2020 · 1 comment

Comments

@lexidor
Copy link
Contributor

lexidor commented Mar 14, 2020

I had to use it in DontUseAsioJoinLinter and there were 0 known usages.
There are no test cases either.
I figured out the API with some guess work.

The documentation I wrote might not be 100% accurate and it is better to demonstrate the functions capabilities using a couple of tests.

@jjergus
Copy link
Contributor

jjergus commented Mar 19, 2020

there were 0 known usages.

I think it's used from hh-apidoc, definition-finder, and/or user-documentation

But I agree, we should have tests too.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants