Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support Arbitrary Shards & Realms #2228

Open
0xivanov opened this issue Feb 18, 2025 · 0 comments
Open

Support Arbitrary Shards & Realms #2228

0xivanov opened this issue Feb 18, 2025 · 0 comments
Labels
Milestone

Comments

@0xivanov
Copy link
Contributor

Description

The SDKs must support non-zero realm numbers in entity IDs (such as 0.100.0) since Spheres will populate realm values.

We need to validate the SDKs support the following:

  • Specifying a realm number during entity ID construction
  • Using entity IDs with specified realm numbers in transactions
  • Eliminating code that assumes zero for shards and realms

Updated APIs

Several APIs currently offered by the SDKs do not offer support for setting the shard and realm of an entity even though the protobufs do. This will need to be updated to allow the protobuf values to be filled out.

ContractCreateTransaction

  • int64 shard : The shard in which to create the new contract.
    • ContractCreateTransaction setShard(int64)
    • int64 getShard()
  • int64 realm: The realm in which to create the new contract.
    • ContractCreateTransaction setRealm(int64)
    • int64 getRealm()

FileCreateTransaction

  • int64 shard : The shard in which to create the new file.
    • FileCreateTransaction setShard(int64)
    • int64 getShard()
  • int64 realm: The realm in which to create the new file.
    • FileCreateTransaction setRealm(int64)
    • int64 getRealm()

AccountCreateTransaction

  • int64 shard : The shard in which to create the new account.
    • AccountCreateTransaction setShard(int64)
    • int64 getShard()
  • int64 realm: The realm in which to create the new account.
    • AccountCreateTransaction setRealm(int64)
    • int64 getRealm()
@0xivanov 0xivanov added this to the v2.51.0 milestone Feb 18, 2025
@SimiHunjan SimiHunjan added the p1 label Feb 18, 2025
@0xivanov 0xivanov added p2 and removed p1 labels Feb 19, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants