Enhanced error handling

Author: SilverFire

Diff for: src/controllers/PackageController.php

@@ -38,12 +38,26 @@ public function actionUpdate()
             Yii::createObject(PackageUpdateCommand::class, [$package])->run();
         } catch (UpdateRateLimitException $exception) {
             Yii::$app->session->addFlash('rate-limited', true);
-        } catch (\Composer\Downloader\TransportException $exception) {
-            if (stripos($exception->getMessage(), 'not found')) {
+        } catch (\Composer\Downloader\TransportException $e) {
+            if (stripos($e->getMessage(), 'not found')) {
+                Yii::warning('Failed to update ' . $package->getFullName() . ': ' . $e->getMessage(), __METHOD__);
+
                 return $this->renderPartial('not-found', ['package' => $package]);
             }
 
-            return $this->renderPartial('transport-error');
+            throw $e;
+        } catch (\Composer\Repository\InvalidRepositoryException $e) {
+            Yii::warning('Failed to update ' . $package->getFullName() . ': ' . $e->getMessage(), __METHOD__);
+
+            return $this->renderPartial('fetch-error', ['package' => $package, 'exception' => $e]);
+        } catch (Exception $e) {
+            Yii::error([
+                'UNKNOWN error during ' . $package->getFullName() . ' update',
+                get_class($e),
+                $e->getMessage(),
+            ], __METHOD__);
+
+            return $this->renderPartial('fetch-error', ['package' => $package, 'exception' => $e]);
         }
 
         $package->load();

Diff for: src/views/package/details.php

@@ -10,8 +10,6 @@
 
 <?php
 $releases = $package->getReleases();
-ksort($releases);
-$releases = array_reverse($releases);
 ?>
 
 <div class="versions">

Diff for: src/views/package/fetch-error.php

@@ -0,0 +1,31 @@
+<?php
+
+/**
+ * @var \yii\web\View $this
+ * @var \hiqdev\assetpackagist\models\AssetPackage $package
+ * @var \Composer\Repository\InvalidRepositoryException $exception
+ */
+
+use yii\helpers\Html;
+
+$this->title = 'Package update failed';
+
+?>
+<hr/>
+<h3><?= $this->title ?></h3>
+
+<blockquote><?= $exception->getMessage() ?></blockquote>
+
+<?php
+
+if ($package->getType() === 'npm') {
+    $link = Html::a('npmjs.com', 'https://npmjs.com/search?q=' . $package->getName(), ['target' => '_blank']);
+} elseif ($package->getType() === 'bower') {
+    $link = Html::a('bower.io', 'https://bower.io/search?q=' . $package->getName(), ['target' => '_blank']);
+}
+
+?>
+
+<h4>Could you ensure this package exists on <?= $link ?> ?</h4>
+<p>Think asset-packagist is guilty? <?= Html::a('Report on GitHub', 'https://github.com/hiqdev/asset-packagist/issues/new') ?>
+</p>