Skip to content

Commit 1bcc4c1

Browse files
authored
fix: remove accidental cartesian product of blocks_pushes * blocks in pending proposal date query (#62)
1 parent 8b3b844 commit 1bcc4c1

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

src/pg/pg-store.ts

+7-8
Original file line numberDiff line numberDiff line change
@@ -1066,18 +1066,17 @@ export class PgStore extends BasePgStore {
10661066
received_at: Date | null;
10671067
}[]
10681068
>`
1069-
WITH last_confirmed_height AS (
1070-
SELECT GREATEST(
1071-
COALESCE(MAX(b.block_height), 0),
1072-
COALESCE(MAX(bp.block_height), 0)
1073-
) AS height
1074-
FROM blocks b
1075-
LEFT JOIN block_pushes bp ON true
1069+
WITH max_heights AS (
1070+
SELECT
1071+
GREATEST(
1072+
(SELECT COALESCE(MAX(block_height), 0) FROM blocks),
1073+
(SELECT COALESCE(MAX(block_height), 0) FROM block_pushes)
1074+
) AS height
10761075
),
10771076
oldest_pending_proposal AS (
10781077
SELECT received_at
10791078
FROM block_proposals bp
1080-
WHERE bp.block_height > (SELECT height FROM last_confirmed_height)
1079+
WHERE bp.block_height > (SELECT height FROM max_heights)
10811080
ORDER BY received_at ASC
10821081
LIMIT 1
10831082
)

0 commit comments

Comments
 (0)