Signer prometheus metrics #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Vercel deployment URL: https://signer-metrics-c3o641n2q-hirosystems.vercel.app 🚀 |
zone117x
commented
Nov 22, 2024
Comment on lines
+3
to
+5
| // First load default.env to prevent envSchema from throwing errors | ||
| const defaultParsed = dotenv.config({ path: `${__dirname}/default.env` }).parsed; | ||
| dotenv.populate(process.env as Record<string, string>, defaultParsed as Record<string, string>); |
There was a problem hiding this comment.
This is indicative of a problem with our ENV init approach. Our modules have side-effects -- in this case src/env.ts has top-level evaluations to init the ENV object.
These lines setup some env var defaults to prevent that module from throwing errors. A better approach would be to remove side-effects from modules, for example make ENV a getter that only evals on demand.
blockstack-devops
pushed a commit
that referenced
this pull request
Nov 22, 2024
## [0.12.0](v0.11.0...v0.12.0) (2024-11-22) ### Features * signer prometheus metrics ([#61](#61)) ([d7a84f4](d7a84f4))
|
🎉 This PR is included in version 0.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
Adds public prometheus metrics endpoint
/signer-metrics/metrics.