Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: remove unused vercel url #64

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix: remove unused vercel url #64

merged 1 commit into from
Dec 17, 2024

Conversation

beguene
Copy link
Collaborator

@beguene beguene commented Dec 17, 2024

No description provided.

@beguene beguene requested a review from zone117x December 17, 2024 14:23
@github-actions GitHub Actions
Copy link

Vercel deployment URL: https://signer-metrics-43x6zsoai-hirosystems.vercel.app 🚀

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@zone117x zone117x requested a review from rafaelcr December 17, 2024 15:51
zone117x
zone117x reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafaelcr does this change make sense to you?

@rafaelcr
Copy link
Collaborator

hmm don't have too much context on this, @beguene can you explain why that URL is no longer used? In the past we always deployed there for preview builds

@beguene
Copy link
Collaborator Author

beguene commented Dec 17, 2024

@rafaelcr the current https://signer-metrics-api-pbcblockstack-blockstack.vercel.app was taken by someone else as a POC (and could have been taken by anyone) by having the Vercel project signer-metrics-api-pbcblockstack-blockstack. So I think either this repo should have its own Vercel subdomain/project and should always keep it or this url should not be used as preview anymore.

@rafaelcr rafaelcr merged commit e05712d into main Dec 17, 2024
5 checks passed
@rafaelcr rafaelcr deleted the fix/unused-vercel-domain branch December 17, 2024 17:11
blockstack-devops pushed a commit that referenced this pull request Dec 17, 2024
@semantic-release-bot
chore(release): 0.12.2 [skip ci]
6c5505d 
## [0.12.2](v0.12.1...v0.12.2) (2024-12-17)

### Bug Fixes

* remove unused vercel url ([#64](#64)) ([e05712d](e05712d))
@blockstack-devops
Copy link

🎉 This PR is included in version 0.12.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@zone117x zone117x zone117x left review comments

@rafaelcr rafaelcr rafaelcr approved these changes

Assignees
No one assigned
Labels
released
Projects
API Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beguene @rafaelcr @blockstack-devops @zone117x