Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: integrate custom metrics to private endpoint and add signer weight percentage metric #69

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

rafaelcr
Copy link
Collaborator

@rafaelcr rafaelcr commented Jan 17, 2025

Moves Prometheus metrics to private /metrics endpoint on dedicated server. Adds signer_api_signer_weight_percentage gauge to measure current cycle signer weight percentages.

Copy link

github-actions bot commented Jan 17, 2025

Vercel deployment URL: https://signer-metrics-8v5s2wuoo-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/index.ts 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rafaelcr rafaelcr marked this pull request as ready for review January 17, 2025 18:08
Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit but otherwise LGTM! Thank you!

Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rafaelcr rafaelcr merged commit d113b7c into main Jan 17, 2025
4 checks passed
@rafaelcr rafaelcr deleted the fix/metrics branch January 17, 2025 18:41
blockstack-devops pushed a commit that referenced this pull request Jan 17, 2025
## [0.12.4](v0.12.3...v0.12.4) (2025-01-17)

### Bug Fixes

* integrate custom metrics to private endpoint and add signer weight percentage metric ([#69](#69)) ([d113b7c](d113b7c))
@blockstack-devops
Copy link

🎉 This PR is included in version 0.12.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus metric for signer weight % Custom Prometheus metrics not showing
4 participants