Review comment

codepitbull · codepitbull · commit 27f1e2576890 · 2025-03-18T11:56:58.000+01:00
diff --git a/modules/hivemq-edge-module-plc4x/src/main/java/com/hivemq/edge/adapters/plc4x/impl/AbstractPlc4xAdapter.java b/modules/hivemq-edge-module-plc4x/src/main/java/com/hivemq/edge/adapters/plc4x/impl/AbstractPlc4xAdapter.java
@@ -145,13 +145,13 @@ public void start(
                         final Plc4xConnection<T> connection = createConnection();
                         if(connection.isConnected()) {
                             protocolAdapterState.setConnectionStatus(CONNECTED);
+                            this.connection = connection;
                             output.startedSuccessfully();
                         } else {
                             protocolAdapterState.setConnectionStatus(ERROR);
                             output.failStart(new Plc4xException("Unable to connect to device"), "Unable to connect to device");
                         }
 
-                        this.connection = connection;
                     }
                 }
             } else {

Original file line number	Diff line number	Diff line change
`@@ -145,13 +145,13 @@ public void start(`
`145`	`145`	`final Plc4xConnection<T> connection = createConnection();`
`146`	`146`	`if(connection.isConnected()) {`
`147`	`147`	`protocolAdapterState.setConnectionStatus(CONNECTED);`
	`148`	`+ this.connection = connection;`
`148`	`149`	`output.startedSuccessfully();`
`149`	`150`	`} else {`
`150`	`151`	`protocolAdapterState.setConnectionStatus(ERROR);`
`151`	`152`	`output.failStart(new Plc4xException("Unable to connect to device"), "Unable to connect to device");`
`152`	`153`	`}`
`153`	`154`
`154`		`- this.connection = connection;`
`155`	`155`	`}`
`156`	`156`	`}`
`157`	`157`	`} else {`