Added nblink option to control placement of notebook links #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbednar
reviewed
Nov 6, 2018
jbednar
approved these changes
Nov 6, 2018
Co-Authored-By: jlstevens <jlrstevens@gmail.com>
jsignell
reviewed
Nov 6, 2018
nbsite/__main__.py
Outdated
| @@ -32,6 +32,7 @@ def main(args=None): | |||
| generaterst_parser.add_argument('--branch',type=str,help='where to init doc',default='master') | |||
| generaterst_parser.add_argument('--offset',type=int,help='where to init doc',default=0) | |||
| generaterst_parser.add_argument('--overwrite',type=int,help='where to init doc',default=False) | |||
| generaterst_parser.add_argument('--nblink',type=str,help='where to to place notebook links',default='bottom') | |||
There was a problem hiding this comment.
Can there be a list of valid options?
jsignell
reviewed
Nov 6, 2018
|
Looks good! |
|
Yep I will merge this and tag when green unless anyone has qualms |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be a fairly simple change that also introduces some tests that check the generated rst content.