Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Notifications not properly cleaned up when more than 1 exists #4964

Closed
tbronson opened this issue May 29, 2023 · 1 comment · Fixed by #7560
Closed

Notifications not properly cleaned up when more than 1 exists #4964

tbronson opened this issue May 29, 2023 · 1 comment · Fixed by #7560
Milestone

Comments

@tbronson
Copy link

tbronson commented May 29, 2023

Whenever more than 1 Notification is issued, only the last issued one will be properly cleaned and removed from the notification list along with its associated watcher in the _notification_watchers dict, due to timeout or user interaction closing it.

Calling clear() does not cleanup the watchers.

@tbronson
Copy link
Author

Debugging on the javascript side, it seems that the syncing of the notifications array is causing a copy operation on the JS-side, which I'm guessing is creating new Notification objects for any already existing in the array (you can see the all the ids change each time you issue a new notification), while all the watchers and timeout callbacks are tied to the old orphaned Notifications.

I'm not savvy enough yet with Bokeh/Panel internals or coding in javascript to know the best way to fix this issue.

@philippjfr philippjfr modified the milestones: v1.0.4, v1.0.5, v1.1.0, v1.1.1 May 30, 2023
@philippjfr philippjfr modified the milestones: v1.1.1, v1.2.0 Jun 22, 2023
@philippjfr philippjfr modified the milestones: v1.2.0, v1.2.1 Jul 10, 2023
@philippjfr philippjfr modified the milestones: v1.2.1, v1.2.2 Jul 25, 2023
@hoxbro hoxbro modified the milestones: v1.2.2, v1.2.3 Sep 4, 2023
@philippjfr philippjfr modified the milestones: v1.2.3, v1.2.4 Sep 18, 2023
@philippjfr philippjfr modified the milestones: v1.2.4, v1.3.0 Oct 9, 2023
@philippjfr philippjfr modified the milestones: v1.3.0, v1.3.1 Oct 23, 2023
@philippjfr philippjfr modified the milestones: v1.3.1, v1.3.2 Oct 31, 2023
@philippjfr philippjfr modified the milestones: v1.3.2, v1.4.0 Nov 22, 2023
@philippjfr philippjfr modified the milestones: v1.4.0, v1.4.x Mar 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants