Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Optimizations for FiberProduct and Pushout not fully implemented #6

Open
zickgraf opened this issue Aug 15, 2020 · 1 comment
Open

Comments

@zickgraf
Copy link
Member

The optimizations for FiberProduct and Pushout are only partially implemented. This violates specifications (for example, compute a UniversalMorphismIntoFiberProduct of two identity morphisms in FinSets and observe that the third specification in #4 is violated).

The following operations (probably) also have to include the optimization:

  • FiberProductFunctorialWithGivenFiberProducts
  • IsomorphismFromEqualizerOfDirectProductDiagramToFiberProduct
  • IsomorphismFromFiberProductToEqualizerOfDirectProductDiagram
  • MorphismFromFiberProductToSinkWithGivenFiberProduct
  • UniversalMorphismIntoFiberProductWithGivenFiberProduct

(Of course the same for Pushout). I'm not 100% sure about the non-withgiven operations, I think they should be fine.

@mohamed-barakat
Copy link
Member

Yes, thank you very much, I am aware of this. I should have written this issue immediately after partially implementing the optimization.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants