Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(boards): case-sensitive board names in url #2454

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Feb 28, 2025


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes #2218

Tried it out with board named GuGuS and was able to open it with /boards/gugus:
image

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Feb 28, 2025
@Meierschlumpf Meierschlumpf self-assigned this Feb 28, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner February 28, 2025 21:59
Copy link

deepsource-io bot commented Feb 28, 2025

Here's the code health analysis summary for commits f0b9324..6837c91. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.07% 9676 / 41934
🔵 Statements 23.07% 9676 / 41934
🔵 Functions 29.55% 399 / 1350
🔵 Branches 65.2% 1162 / 1782
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/api/src/router/board.ts 59.55% 82.16% 82.35% 59.55% 46-54, 57-64, 70-95, 171-240, 277-488, 507-511, 524-526, 529-531, 539, 729-923, 944-964, 1079-1094, 1183, 1202, 1213-1228, 1233-1234, 1256-1271, 1276-1277, 1296-1298, 1323-1325, 1416-1417, 1441-1442, 1546-1550, 1606-1607, 1615-1616
Generated in workflow #5317 for commit 6837c91 by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf merged commit c0e3544 into dev Mar 1, 2025
14 checks passed
@Meierschlumpf Meierschlumpf deleted the case-insensitive-board-name branch March 1, 2025 16:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Case-sensitive board names and URLs
2 participants