Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(logs): add special case for axios error to prevent huge error messages #2468

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Some axios errors have a length of more than 1500 lines
Closes #2204

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Mar 1, 2025
@Meierschlumpf Meierschlumpf self-assigned this Mar 1, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner March 1, 2025 22:42
Copy link

deepsource-io bot commented Mar 1, 2025

Here's the code health analysis summary for commits 80c2040..fbf0a2a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Mar 1, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.06% 9680 / 41970
🔵 Statements 23.06% 9680 / 41970
🔵 Functions 29.51% 399 / 1352
🔵 Branches 65.2% 1162 / 1782
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/cron-jobs-core/src/creator.ts 54.76% 87.5% 40% 54.76% 33-63, 86-95, 114-115
Generated in workflow #5344 for commit fbf0a2a by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf merged commit 9eb7663 into dev Mar 2, 2025
13 checks passed
@Meierschlumpf Meierschlumpf deleted the huge-axios-errors branch March 2, 2025 09:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Homarr 1.0+ taking an absurdly large amount of storage
2 participants