Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump voluptuous to 0.15.0 #120268

Closed
wants to merge 19 commits into from
Closed

Bump voluptuous to 0.15.0 #120268

wants to merge 19 commits into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 23, 2024

Proposed change

changelog: alecthomas/voluptuous@0.13.1...0.15.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed core dependency small-pr PRs with less than 30 lines. labels Jun 23, 2024
@bdraco
Copy link
Member Author

bdraco commented Jun 23, 2024

It looks like hassfest fails because vol.Remove no longer works the same way

vol.Remove(vol.All(str, starts_with_dot)): object,

@bdraco
Copy link
Member Author

bdraco commented Jun 23, 2024

Might be that alecthomas/voluptuous#479 introduced a regression

@bdraco
Copy link
Member Author

bdraco commented Jun 23, 2024

There are a lot of places where we use a comparable object like timedelta for vol.Range or Min/Max
Error: homeassistant/components/geniushub/__init__.py:95: error: Argument "max" to "Range" has incompatible type "timedelta"; expected "int | float | None" [arg-type]

python/typing#59 (comment)

@bdraco
Copy link
Member Author

bdraco commented Jun 23, 2024

description is now typed to str | None but we use all sorts of types there

Error: homeassistant/components/verisure/config_flow.py:326: error: Argument "description" to "Optional" has incompatible type "dict[str, Any]"; expected "str | None" [arg-type]

@bdraco
Copy link
Member Author

bdraco commented Jun 25, 2024

down to Found 513 errors in 175 files (checked 7076 source files) with Marc's fixes

@cdce8p cdce8p mentioned this pull request Jun 25, 2024
20 tasks
@cdce8p
Copy link
Member

cdce8p commented Jun 25, 2024

down to Found 513 errors in 175 files (checked 7076 source files) with Marc's fixes

I still have some changes left to do 😉
E.g. #120407 which should fix another 50+ errors.

@bdraco
Copy link
Member Author

bdraco commented Jun 25, 2024

Found 449 errors in 150 files (checked 7077 source files)

@cdce8p cdce8p mentioned this pull request Jun 25, 2024
20 tasks
@bdraco
Copy link
Member Author

bdraco commented Jun 25, 2024

Found 388 errors in 133 files (checked 7077 source files)

@bdraco
Copy link
Member Author

bdraco commented Jun 25, 2024

Found 349 errors in 120 files (checked 7077 source files)

@bdraco
Copy link
Member Author

bdraco commented Jun 25, 2024

Found 324 errors in 95 files (checked 7077 source files)

@bdraco
Copy link
Member Author

bdraco commented Jun 26, 2024

Found 277 errors in 72 files (checked 7084 source files)

@cdce8p cdce8p mentioned this pull request Jun 26, 2024
20 tasks
@bdraco
Copy link
Member Author

bdraco commented Jun 26, 2024

Found 274 errors in 71 files (checked 7084 source files)

@cdce8p cdce8p mentioned this pull request Jun 26, 2024
20 tasks
@cdce8p
Copy link
Member

cdce8p commented Jun 26, 2024

Found 254 errors in 65 files (checked 7086 source files)

@cdce8p
Copy link
Member

cdce8p commented Jun 26, 2024

Found 215 errors in 51 files (checked 7090 source files)

@cdce8p cdce8p mentioned this pull request Jun 27, 2024
20 tasks
@cdce8p
Copy link
Member

cdce8p commented Jun 27, 2024

Success: no issues found in 7090 source files

Opened #120631 with the update to 0.15.1.

@cdce8p cdce8p closed this Jun 27, 2024
@cdce8p cdce8p deleted the bump_vol branch June 27, 2024 04:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants