Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update voluptuous to 0.15.2 #120631

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Update voluptuous to 0.15.2 #120631

merged 5 commits into from
Jul 2, 2024

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jun 27, 2024

Proposed change

Replaces #120268
alecthomas/voluptuous@0.13.1...0.15.2
https://github.com/alecthomas/voluptuous/releases/tag/0.15.1
https://github.com/alecthomas/voluptuous/releases/tag/0.15.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@cdce8p cdce8p requested a review from a team as a code owner June 27, 2024 04:37
@home-assistant home-assistant bot added cla-signed core dependency small-pr PRs with less than 30 lines. labels Jun 27, 2024
@cdce8p cdce8p marked this pull request as draft June 27, 2024 04:37
@cdce8p cdce8p marked this pull request as ready for review June 27, 2024 04:47
@cdce8p cdce8p requested a review from bdraco June 27, 2024 04:48
@cdce8p cdce8p mentioned this pull request Jun 27, 2024
20 tasks
@bdraco
Copy link
Member

bdraco commented Jun 27, 2024

  raise er.MultipleInvalid(errors)
voluptuous.error.MultipleInvalid: not a valid value @ data['name_raw']

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/runner/work/core/core/homeassistant/components/snips/__init__.py", line 149, in message_received
    intent_response = await intent.async_handle(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/core/core/homeassistant/helpers/intent.py", line 143, in async_handle
    raise InvalidSlotInfo(f"Received invalid slot info for {intent_type}") from err
homeassistant.helpers.intent.InvalidSlotInfo: Received invalid slot info for Lights

Looks like it might be an actual regression?

@epenet epenet marked this pull request as draft June 27, 2024 11:54
@epenet
Copy link
Contributor

epenet commented Jun 27, 2024

Marked as draft as the test failure is related to the PR.

@cdce8p
Copy link
Member Author

cdce8p commented Jun 28, 2024

Looks like it might be an actual regression?

Yes. Fix in alecthomas/voluptuous#522

@cdce8p cdce8p added the waiting-for-upstream We're waiting for a change upstream label Jun 28, 2024
@cdce8p cdce8p force-pushed the update-voluptuous-0.15.1 branch from bcd32c0 to 2551b5b Compare July 2, 2024 19:10
@cdce8p cdce8p changed the title Update voluptuous to 0.15.1 Update voluptuous to 0.15.2 Jul 2, 2024
@cdce8p cdce8p removed the waiting-for-upstream We're waiting for a change upstream label Jul 2, 2024
@bdraco
Copy link
Member

bdraco commented Jul 2, 2024

Probably should merge in dev again before merging in case there are new places that need fixes

@cdce8p
Copy link
Member Author

cdce8p commented Jul 2, 2024

Probably should merge in dev again before merging in case there are new places that need fixes

Just did a rebase with force-push. Unless the latest one or two commits contain breaking changes, we should be good here.

@cdce8p cdce8p marked this pull request as ready for review July 2, 2024 19:40
@bdraco
Copy link
Member

bdraco commented Jul 2, 2024

Tested on production x2. All good afaict

@bdraco
Copy link
Member

bdraco commented Jul 2, 2024

Thanks @cdce8p

@bdraco
Copy link
Member

bdraco commented Jul 2, 2024

Cla bot check seems stuck

Will close reopen and merge to see if it will clear

@bdraco bdraco closed this Jul 2, 2024
@bdraco bdraco reopened this Jul 2, 2024
@bdraco
Copy link
Member

bdraco commented Jul 2, 2024

Looks ok now.

@bdraco bdraco merged commit 0e52d14 into dev Jul 2, 2024
6 of 24 checks passed
@bdraco bdraco deleted the update-voluptuous-0.15.1 branch July 2, 2024 19:57
@bdraco
Copy link
Member

bdraco commented Jul 2, 2024

Nice. This will help mqtt startup time

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants