Add spacing card #24403
Open
Add spacing card #24403
+170
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have 1x1 default size on the grid? Also, can we color it in preview mode so it appears in edit mode? |
bramkragten
reviewed
Feb 26, 2025
bramkragten
reviewed
Feb 26, 2025
Comment on lines
+269
to
+271
| .filter((card: Card) => | ||
| this.isSectionsView ? true : !card.sectionsViewOnly | ||
| ) |
There was a problem hiding this comment.
Can we instead just skip the filter? It will still iterate over all the items now
const viewCards = this.isSectionsView ? coreCards : coreCards.filter(card => !card.sectionsViewOnly);
let cards = viewCards.map(...)
bramkragten
reviewed
Feb 26, 2025
| @@ -66,6 +66,7 @@ export interface Card { | |||
| showElement?: boolean; | |||
| isCustom?: boolean; | |||
| isSuggested?: boolean; | |||
| sectionsViewOnly?: boolean; | |||
There was a problem hiding this comment.
Should this instead be a list of allowed (or disallowed?) view types?
bramkragten
reviewed
Feb 26, 2025
| @@ -146,6 +146,10 @@ export class HuiCreateDialogCard | |||
| .lovelace=${this._params.lovelaceConfig} | |||
| .hass=${this.hass} | |||
| @config-changed=${this._handleCardPicked} | |||
| .isSectionsView=${this._isSectionsView( | |||
There was a problem hiding this comment.
I would rather do this by just passing the view type
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: