Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

homebridge-daikin-local-platform #677

Closed
tasict opened this issue Jan 9, 2024 · 11 comments
Closed

homebridge-daikin-local-platform #677

tasict opened this issue Jan 9, 2024 · 11 comments
Labels
verified use when a plugin meets the criteria - adds the verified badge text

Comments

@tasict
Copy link

tasict commented Jan 9, 2024

Link To GitHub Repo

https://github.com/tasict/homebridge-daikin-local-platform

Link To NPM Package

https://www.npmjs.com/package/homebridge-daikin-local-platform

Plugin Icon (Optional)

No response

@tasict tasict added the pending the label given to a new verification/icon request label Jan 9, 2024
Copy link

github-actions bot commented Jan 9, 2024

✅ Pre-checks completed successfully.

@bwp91 bwp91 added the currently-reviewing use for starting a review - adds a comment with the verification list with empty checkboxes label Feb 11, 2024
Copy link

github-actions bot commented Feb 11, 2024

  • General
    • The plugin must be of type dynamic platform.
    • The plugin must not offer the same nor less functionality than that of any existing verified plugin.
  • Repo
    • The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.
    • A GitHub release should be created for every new version of your plugin, with release notes.
  • Environment
    • The plugin must run on all supported LTS versions of Node.js, at the time of writing this is Node v18 and v20.
    • The plugin must successfully install and not start unless it is configured.
    • The plugin must not execute post-install scripts that modify the users' system in any way.
    • The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
  • Codebase
    • The plugin must implement the Homebridge Plugin Settings GUI.
    • The plugin must not contain any analytics or calls that enable you to track the user.
    • If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
    • The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.



Comment /check to run checks again.

@tasict
Copy link
Author

tasict commented Feb 11, 2024

/check

@github-actions github-actions bot removed the currently-reviewing use for starting a review - adds a comment with the verification list with empty checkboxes label Feb 11, 2024
Copy link

✅ Pre-checks completed successfully.

@bwp91
Copy link
Contributor

bwp91 commented Feb 11, 2024

Hi @tasict

I noticed in your README that you already have the homebridge verified badge, this really should not be there until your plugin has been verified.

Screenshot 2024-02-11 at 00 34 18

I had a couple of questions about verification:

  • we ideally would like just one verified plugin per plugin/functionality, and I noticed this plugin is already verified:
  • github releases are necessary for verification
  • in which file do you use the cheerio dependency in your package json file?

@bwp91 bwp91 added awaiting-user-reply use after review has started - awaiting user to reply to a comment and removed pending the label given to a new verification/icon request labels Feb 11, 2024
@tasict
Copy link
Author

tasict commented Feb 11, 2024

cbrandlehner/homebridge-daikin-local#340

Due to certain factors, original plugin cannot support the new version of the air conditioner firmware. The author mentioned that, due to the architecture, it is not feasible to provide support by modifying the code in the short term. To ensure compatibility with HomeKit and continue using Homebridge for my air conditioner, I collaborated with the author to completely rewrite the plugin, enabling support for the new air conditioning firmware. If you have other aspects to mention, I will make the necessary modifications.

@tasict
Copy link
Author

tasict commented Feb 13, 2024

@bwp91 Hi, I have modified the code and documentation. Please assist in reviewing the latest version. Thank you.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale used for stale issues label Mar 14, 2024
@tasict
Copy link
Author

tasict commented Mar 14, 2024

@bwp91 Any update?

@github-actions github-actions bot removed the stale used for stale issues label Mar 15, 2024
@bwp91 bwp91 added verified use when a plugin meets the criteria - adds the verified badge text and removed awaiting-user-reply use after review has started - awaiting user to reply to a comment labels Mar 16, 2024
Copy link

Congratulations! Your plugin has been verified.

You can now add one of the Verified by Homebridge badges to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

verified-by-homebridge

[![verified-by-homebridge](https://img.shields.io/badge/homebridge-verified-blueviolet?color=%23491F59&style=for-the-badge&logoColor=%23FFFFFF&logo=homebridge)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

Thank you for your contribution to the Homebridge Community.
https://homebridge.io

bwp91 added a commit that referenced this issue Mar 16, 2024
@bwp91
Copy link
Contributor

bwp91 commented Mar 16, 2024

Apologies for delay - thanks for the info - all verified!

@bwp91 bwp91 closed this as completed Mar 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
verified use when a plugin meets the criteria - adds the verified badge text
Projects
None yet
Development

No branches or pull requests

2 participants