Cross-origin redirect inside of an iframe is interpreted as a redirect for the app

[glennfu]

I have a page loading with a standard inline YouTube embed:

<iframe
  width="480"
  height="270"
  src="https://www.youtube.com/embed/dQw4w9WgXcQ?playsinline=1&showinfo=0&rel=0&iv_load_policy=3&color=white"
  frameborder="0"
  allowfullscreen
></iframe>

Since updating from 1.1.0 to 1.1.1, I assume as a result of #70, when this page loads it instantly bounces over to the Safari app at this YouTube url.

I'm not sure what the best solution is, but my hope would be that in detecting things like Cross-origin redirects, it could safely ignore those that aren't happening on the parent frame.

To reproduce, you can take the Demo app and locally serve up just the iframe html above.

[noah44846]

I also encountered the same issue, but for the Google Maps embed. For me, it also worked in 1.1.0 but not in 1.1.1. Here is the iframe:

<iframe
    allowfullscreen=""
    class="mb-2 rounded-3"
    frameborder="0"
    height="150"
    width="100%"
    src="https://www.google.com/maps/embed/v1/place?key=<key...>&q=<query...>&zoom=15"
></iframe>

The thing is that for me when I navigate to the page the containing the iframe there is no issue, but when I pull-to-refresh the WebView it opens the embedded link in the browser.

[darthdie]

We're encountering the same thing and have opened up a reproducible example here:
hotwired/hotwire-native-demo#13 

It seems to only happen during a ColdBootVisit for us.

Adding

        guard let targetFrame = navigationAction.targetFrame, targetFrame.isMainFrame else {
            decisionHandler(.cancel)
            return
        }

into ColdBootVisit func webView(_ webView: WKWebView, decidePolicyFor navigationAction: WKNavigationAction, decisionHandler: @escaping (WKNavigationActionPolicy) -> Void)

Fixes the issue.

[svara]

Hey guys, we've merged #80 which should address this issue.
Could you give it a test on main? Thanks!

The thing is that for me when I navigate to the page the containing the iframe there is no issue, but when I pull-to-refresh the WebView it opens the embedded link in the browser.

@noah44846 Only a cold boot visit is affected by this. Since pull to refresh initiates a cold boot visit, you ran into this behaviour.

[noah44846]

Hey guys, we've merged #80 which should address this issue. Could you give it a test on main? Thanks!

The thing is that for me when I navigate to the page the containing the iframe there is no issue, but when I pull-to-refresh the WebView it opens the embedded link in the browser.

@noah44846 Only a cold boot visit is affected by this. Since pull to refresh initiates a cold boot visit, you ran into this behaviour.

I tested it on our project, and it fixes the issue we've had. Thanks!

[glennfu]

Yes this solves my issue. Thank you!